From: Daniel Baluta <daniel.baluta@intel.com>
To: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [Outreachy kernel] [PATCH] iio: Add ABI documentation for in_magn offset and raw values
Date: Fri, 13 Mar 2015 15:59:08 +0200 [thread overview]
Message-ID: <CAEnQRZD7zQdfX_uMa74dD1Od_ZKzuwtriu22tmjsKJxmif8KOg@mail.gmail.com> (raw)
In-Reply-To: <1426254366-27021-1-git-send-email-darshanapadmadas@gmail.com>
On Fri, Mar 13, 2015 at 3:46 PM, Darshana Padmadas
<darshanapadmadas@gmail.com> wrote:
> This patch adds ABI documentation entries for in_magn_offset
> and in_magn_raw. At least one user exists, mag3110 and
> hid-sensor-magn-3d in drivers/iio/magnetometer.
Hi,
Because we have:
* .modified field set to 1
* .channel2 set to some modifier (e.g IIO_MOD_X)
* info_mask_separate set to IIO_CHAN_INFO_RAW
resulting attributes will be of the form:
* in_magn_x_raw, in_magn_y_raw, in_magn_z_raw etc.
The patch looks good for offset attribute because in hid-sensor-magn-3d we have:
* info_mask_shared_by_type set to IIO_CHAN_OFFSET.
Please use the dummy driver to confirm this. And resend the patch keeping only
the entry for offset.
thanks,
Daniel.
prev parent reply other threads:[~2015-03-13 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 13:46 [PATCH] iio: Add ABI documentation for in_magn offset and raw values Darshana Padmadas
2015-03-13 13:59 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZD7zQdfX_uMa74dD1Od_ZKzuwtriu22tmjsKJxmif8KOg@mail.gmail.com \
--to=daniel.baluta@intel.com \
--cc=darshanapadmadas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).