From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"cpgs@samsung.com" <cpgs@samsung.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 3/4] ARM: DTS: use new compatible string as per the documentation
Date: Tue, 24 Jun 2014 19:11:39 +0530 [thread overview]
Message-ID: <CAHfPSqAEuFRSrv5BHw05aK7TiMzXxveriKx9vdqhLc7AxF=i9Q@mail.gmail.com> (raw)
In-Reply-To: <20140624133314.GJ5856@leverpostej>
Hello Mark,
On 24 June 2014 19:03, Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Jun 24, 2014 at 01:19:15PM +0100, Naveen Krishna Chatradhi wrote:
>> As Murata is the Manufactures the NTC thermistors. The vendor
>> name in the compatibility is preposed to change to "murata, ncpXXX"
>>
>> This patch uses the new compatibility string in exynos4412 based
>> Trats2 board.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> 1. Updates the thermistor node in Exynos4412 based Trats2 dts
>> using the new DT bindings for NTC thermistors updated with vendor-prefix
>>
>> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
>> index 11967f4..d35755a 100644
>> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
>> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
>> @@ -771,7 +771,7 @@
>> };
>>
>> thermistor-ap@0 {
>> - compatible = "ntc,ncp15wb473";
>> + compatible = "murata,ncp15wb473";
>
> So the previous patch woul have broken this board?
Will keep the deprecated binding. But, still change here.
As, this is the only board currently using the NTC thermistors.
>
> Mark.
>
>> pullup-uv = <1800000>; /* VCC_1.8V_AP */
>> pullup-ohm = <100000>; /* 100K */
>> pulldown-ohm = <100000>; /* 100K */
>> @@ -779,7 +779,7 @@
>> };
>>
>> thermistor-battery@1 {
>> - compatible = "ntc,ncp15wb473";
>> + compatible = "murata,ncp15wb473";
>> pullup-uv = <1800000>; /* VCC_1.8V_AP */
>> pullup-ohm = <100000>; /* 100K */
>> pulldown-ohm = <100000>; /* 100K */
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
Shine bright,
(: Nav :)
next prev parent reply other threads:[~2014-06-24 13:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 12:19 [PATCH 0/4] hwmon: ntc_thermistor: prepose vendor prefix change Naveen Krishna Chatradhi
2014-06-24 12:19 ` [PATCH 1/4] devicetree: bindings: Document murata vendor prefix Naveen Krishna Chatradhi
2014-06-24 13:30 ` Mark Rutland
2014-06-24 13:38 ` Naveen Krishna Ch
2014-06-24 12:19 ` [PATCH 2/4] hwmon: ntc_thermistor: Use the manufacturer name properly Naveen Krishna Chatradhi
2014-06-24 13:32 ` Mark Rutland
2014-06-24 13:40 ` Naveen Krishna Ch
2014-06-24 12:19 ` [PATCH 3/4] ARM: DTS: use new compatible string as per the documentation Naveen Krishna Chatradhi
2014-06-24 13:33 ` Mark Rutland
2014-06-24 13:41 ` Naveen Krishna Ch [this message]
2014-06-24 12:19 ` [PATCH 4/4] ARM: DTS: Add NTC thermistor nodes as child nodes to ADC Naveen Krishna Chatradhi
2014-06-24 21:54 ` Doug Anderson
2014-06-25 5:04 ` Naveen Krishna Ch
2014-06-25 7:37 ` Javier Martinez Canillas
2014-06-25 17:00 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHfPSqAEuFRSrv5BHw05aK7TiMzXxveriKx9vdqhLc7AxF=i9Q@mail.gmail.com' \
--to=naveenkrishna.ch@gmail.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).