From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 1/4] staging: iio: frequency: ad9832: Fix alignment for DMA safety
Date: Mon, 8 Aug 2022 11:18:34 +0200 [thread overview]
Message-ID: <CAHp75Vd34hOAMpeCwcYjnuVWUSN7WuGGwc1qiKqNp+xpmsEXkg@mail.gmail.com> (raw)
In-Reply-To: <20220807151218.656881-2-jic23@kernel.org>
On Sun, Aug 7, 2022 at 5:26 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> ____cacheline_aligned is an insufficient guarantee for non-coherent DMA
> on platforms with 128 byte cachelines above L1. Switch to the updated
> IIO_DMA_MINALIGN definition.
...
> union {
> - __be16 freq_data[4]____cacheline_aligned;
> + __be16 freq_data[4] __aligned(IIO_DMA_MINALIGN);
> __be16 phase_data[2];
> __be16 data;
> };
Hmm... Can we rather mark the entire union with it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-08 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 15:12 [PATCH 0/4] staging: iio: DMA alignment fixes Jonathan Cameron
2022-08-07 15:12 ` [PATCH 1/4] staging: iio: frequency: ad9832: Fix alignment for DMA safety Jonathan Cameron
2022-08-08 9:18 ` Andy Shevchenko [this message]
2022-08-08 14:14 ` Jonathan Cameron
2022-08-07 15:12 ` [PATCH 2/4] staging: iio: frequency: ad9834: " Jonathan Cameron
2022-08-07 15:12 ` [PATCH 3/4] staging: iio: meter: ade7854: " Jonathan Cameron
2022-08-07 15:12 ` [PATCH 4/4] staging: iio: resolver: ad2s1210: " Jonathan Cameron
2022-08-08 9:20 ` [PATCH 0/4] staging: iio: DMA alignment fixes Andy Shevchenko
2022-08-13 16:01 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd34hOAMpeCwcYjnuVWUSN7WuGGwc1qiKqNp+xpmsEXkg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).