* [PATCH] iio: potentiostat: lmp91000: add LMP91002 support
@ 2018-04-27 2:15 Matt Ranostay
2018-04-27 2:17 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2018-04-27 2:15 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Matt Ranostay, device-tree
LMP91002 is register compatible so add devicetree and i2c client ids
Cc: device-tree@vger.kernel.org
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt | 7 ++++---
drivers/iio/potentiostat/lmp91000.c | 2 ++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
index b9b621e94cd7..d51639f0ebbf 100644
--- a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
+++ b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
@@ -1,10 +1,11 @@
-* Texas Instruments LMP91000 potentiostat
+* Texas Instruments LMP91000 series of potentiostats
-http://www.ti.com/lit/ds/symlink/lmp91000.pdf
+LMP91000: http://www.ti.com/lit/ds/symlink/lmp91000.pdf
+LMP91002: http://www.ti.com/lit/ds/symlink/lmp91002.pdf
Required properties:
- - compatible: should be "ti,lmp91000"
+ - compatible: should be "ti,lmp91000" or "ti,lmp91002"
- reg: the I2C address of the device
- io-channels: the phandle of the iio provider
diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
index 85714055cc74..90e895adf997 100644
--- a/drivers/iio/potentiostat/lmp91000.c
+++ b/drivers/iio/potentiostat/lmp91000.c
@@ -411,12 +411,14 @@ static int lmp91000_remove(struct i2c_client *client)
static const struct of_device_id lmp91000_of_match[] = {
{ .compatible = "ti,lmp91000", },
+ { .compatible = "ti,lmp91002", },
{ },
};
MODULE_DEVICE_TABLE(of, lmp91000_of_match);
static const struct i2c_device_id lmp91000_id[] = {
{ "lmp91000", 0 },
+ { "lmp91002", 0 },
{}
};
MODULE_DEVICE_TABLE(i2c, lmp91000_id);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: potentiostat: lmp91000: add LMP91002 support
2018-04-27 2:15 [PATCH] iio: potentiostat: lmp91000: add LMP91002 support Matt Ranostay
@ 2018-04-27 2:17 ` Matt Ranostay
2018-04-28 16:04 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2018-04-27 2:17 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Matt Ranostay, devicetree
On Thu, Apr 26, 2018 at 7:15 PM, Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
> LMP91002 is register compatible so add devicetree and i2c client ids
>
> Cc: device-tree@vger.kernel.org
*sigh* should be devicetree@vger.kernel.org ... adding correct CC
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
> Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt | 7 ++++---
> drivers/iio/potentiostat/lmp91000.c | 2 ++
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> index b9b621e94cd7..d51639f0ebbf 100644
> --- a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> +++ b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> @@ -1,10 +1,11 @@
> -* Texas Instruments LMP91000 potentiostat
> +* Texas Instruments LMP91000 series of potentiostats
>
> -http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> +LMP91000: http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> +LMP91002: http://www.ti.com/lit/ds/symlink/lmp91002.pdf
>
> Required properties:
>
> - - compatible: should be "ti,lmp91000"
> + - compatible: should be "ti,lmp91000" or "ti,lmp91002"
> - reg: the I2C address of the device
> - io-channels: the phandle of the iio provider
>
> diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> index 85714055cc74..90e895adf997 100644
> --- a/drivers/iio/potentiostat/lmp91000.c
> +++ b/drivers/iio/potentiostat/lmp91000.c
> @@ -411,12 +411,14 @@ static int lmp91000_remove(struct i2c_client *client)
>
> static const struct of_device_id lmp91000_of_match[] = {
> { .compatible = "ti,lmp91000", },
> + { .compatible = "ti,lmp91002", },
> { },
> };
> MODULE_DEVICE_TABLE(of, lmp91000_of_match);
>
> static const struct i2c_device_id lmp91000_id[] = {
> { "lmp91000", 0 },
> + { "lmp91002", 0 },
> {}
> };
> MODULE_DEVICE_TABLE(i2c, lmp91000_id);
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: potentiostat: lmp91000: add LMP91002 support
2018-04-27 2:17 ` Matt Ranostay
@ 2018-04-28 16:04 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2018-04-28 16:04 UTC (permalink / raw)
To: Matt Ranostay; +Cc: linux-iio, devicetree
On Thu, 26 Apr 2018 19:17:09 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> On Thu, Apr 26, 2018 at 7:15 PM, Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
> > LMP91002 is register compatible so add devicetree and i2c client ids
> >
> > Cc: device-tree@vger.kernel.org
>
> *sigh* should be devicetree@vger.kernel.org ... adding correct CC
>
> > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> > ---
> > Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt | 7 ++++---
> > drivers/iio/potentiostat/lmp91000.c | 2 ++
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > index b9b621e94cd7..d51639f0ebbf 100644
> > --- a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > +++ b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > @@ -1,10 +1,11 @@
> > -* Texas Instruments LMP91000 potentiostat
> > +* Texas Instruments LMP91000 series of potentiostats
> >
> > -http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> > +LMP91000: http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> > +LMP91002: http://www.ti.com/lit/ds/symlink/lmp91002.pdf
> >
> > Required properties:
> >
> > - - compatible: should be "ti,lmp91000"
> > + - compatible: should be "ti,lmp91000" or "ti,lmp91002"
Please put each entry on a new line. Reduces churn going forward.
Thanks,
Jonathan
> > - reg: the I2C address of the device
> > - io-channels: the phandle of the iio provider
> >
> > diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> > index 85714055cc74..90e895adf997 100644
> > --- a/drivers/iio/potentiostat/lmp91000.c
> > +++ b/drivers/iio/potentiostat/lmp91000.c
> > @@ -411,12 +411,14 @@ static int lmp91000_remove(struct i2c_client *client)
> >
> > static const struct of_device_id lmp91000_of_match[] = {
> > { .compatible = "ti,lmp91000", },
> > + { .compatible = "ti,lmp91002", },
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, lmp91000_of_match);
> >
> > static const struct i2c_device_id lmp91000_id[] = {
> > { "lmp91000", 0 },
> > + { "lmp91002", 0 },
> > {}
> > };
> > MODULE_DEVICE_TABLE(i2c, lmp91000_id);
> > --
> > 2.14.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-28 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-27 2:15 [PATCH] iio: potentiostat: lmp91000: add LMP91002 support Matt Ranostay
2018-04-27 2:17 ` Matt Ranostay
2018-04-28 16:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).