From: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
To: michael.hennerich@analog.com
Cc: gregkh@linuxfoundation.org, jic23@kernel.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] iio: ad9523: Fix argument type mismatch
Date: Mon, 11 Jun 2012 14:32:57 +0530 [thread overview]
Message-ID: <CAM=Q2ctNYnq9S9fr4K6sh+k3311nMON8Yho+-vAdd3dSdOXRHg@mail.gmail.com> (raw)
In-Reply-To: <1339401064-5218-1-git-send-email-michael.hennerich@analog.com>
Hi Michael,
On Mon, Jun 11, 2012 at 1:21 PM, <michael.hennerich@analog.com> wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
> =A0 =A0 =A0 =A0 warn: value 2 can't fit into 1 'out'
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> =A0drivers/iio/frequency/ad9523.c | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad952=
3.c
> index 7272924..43f47d9 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev=
)
> =A0}
>
> =A0static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, bo=
ol out)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, un=
signed out)
Unsigned defaults to unsigned int right shouldnt it be a char?
Or am I missing something.
next prev parent reply other threads:[~2012-06-11 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 7:51 [PATCH] iio: ad9523: Fix argument type mismatch michael.hennerich
2012-06-11 9:02 ` Shubhrajyoti Datta [this message]
2012-06-11 9:15 ` Michael Hennerich
2012-06-11 11:17 ` Shubhrajyoti Datta
2012-06-11 11:36 ` Lars-Peter Clausen
2012-06-11 12:29 ` Shubhrajyoti Datta
-- strict thread matches above, loose matches on Subject: below --
2012-06-08 11:04 michael.hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=Q2ctNYnq9S9fr4K6sh+k3311nMON8Yho+-vAdd3dSdOXRHg@mail.gmail.com' \
--to=omaplinuxkernel@gmail.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).