From: Abhisit Sangjan <s.abhisit@gmail.com>
To: jmondi <jacopo@jmondi.org>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
fabrice.gasnier@st.com, Lee Jones <lee.jones@linaro.org>,
robh@kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
marek.vasut+renesas@gmail.com, jacopo+renesas@jmondi.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/5] iio: Add support for LMP92001 ADC
Date: Fri, 18 Aug 2017 14:42:59 +0700 [thread overview]
Message-ID: <CAMV_pUaM5MAYL_R+0_9uW52fmp+c5XjBNyWeMFZqCx3MUWD59g@mail.gmail.com> (raw)
In-Reply-To: <CAMV_pUYqGnDQmn+j9y85e9y8f7nuewAHTnDxm-goJ+mW-kMhUg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6317 bytes --]
Hi Jmondi,
After I removed those cases, I got warnings "no handled in switch".
On Fri, Aug 18, 2017 at 10:15 AM, Abhisit Sangjan <s.abhisit@gmail.com>
wrote:
> Hi Jmondi,
>
> On Fri, Aug 18, 2017 at 9:58 AM, jmondi <jacopo@jmondi.org> wrote:
>
>> Hi Abhisit,
>>
>> On Fri, Aug 18, 2017 at 09:34:16AM +0700, Abhisit Sangjan wrote:
>> > Hi Jmondi,
>> >
>> > Thank you for your recommend, I am testing the code will be send the new
>> > patch in soon.
>>
>> [snip]
>>
>> > > > > +
>> > > > > + switch (mask)
>> > > > > + {
>> > > > > + case IIO_CHAN_INFO_RAW:
>> > > > > + switch (channel->type) {
>> > > > > + case IIO_VOLTAGE:
>> > > > > + case IIO_TEMP:
>> > > > > + *val = code;
>> > > > > + return IIO_VAL_INT;
>> > > > > + default:
>> > > > > + break;
>> > > > > + }
>> > > > > + break;
>> > > > > + default:
>> > > > > + break;
>> > >
>> > > You can remove these default cases or return -EINVAL here.
>> > >
>> >
>> > Abhisit: Okay, I will remove it.
>> > Could you tell me in detail. Sorry, I do not understand the
>> > Technical.
>>
>> This can potentially be reduced to
>>
>> switch (mask) {
>> case IIO_CHAN_INFO_RAW:
>> switch (channel->type) {
>> case IIO_VOLTAGE:
>> case IIO_TEMP:
>> *val = code;
>> return IIO_VAL_INT;
>> }
>> }
>>
>> return -EINVAL;
>>
>>
>> But that's definitely not a big deal, there are no optimization in
>> this code change, just less typing and less default: and break; here
>> and there
>>
>
> Abhisit: Thank you so much.
>
Abhisit: If I remove those default cases, I got the warning. How do I would
do next to fix warning? Should I leave this code as it?
# What have I changed.
diff --git a/drivers/iio/adc/lmp92001-adc.c b/drivers/iio/adc/lmp92001-adc.c
index 68f7a6c..ebc6423 100644
--- a/drivers/iio/adc/lmp92001-adc.c
+++ b/drivers/iio/adc/lmp92001-adc.c
@@ -92,12 +92,7 @@ static int lmp92001_read_raw(struct iio_dev *indio_dev,
case IIO_TEMP:
*val = code;
return IIO_VAL_INT;
- default:
- break;
}
- break;
- default:
- break;
}
return -EINVAL;
# Compilation.
CC drivers/iio/adc/lmp92001-adc.o
drivers/iio/adc/lmp92001-adc.c: In function ‘lmp92001_read_raw’:
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_CURRENT’ not handled in switch [-Wswitch]
switch (channel->type) {
^
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_POWER’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_ACCEL’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_ANGL_VEL’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_MAGN’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_LIGHT’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_INTENSITY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_PROXIMITY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_INCLI’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_ROT’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_ANGL’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_TIMESTAMP’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_CAPACITANCE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_ALTVOLTAGE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_CCT’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_PRESSURE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_HUMIDITYRELATIVE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_ACTIVITY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_STEPS’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_ENERGY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_DISTANCE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_VELOCITY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_CONCENTRATION’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_RESISTANCE’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_PH’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_UVINDEX’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_ELECTRICALCONDUCTIVITY’ not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_COUNT’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value ‘IIO_INDEX’
not handled in switch [-Wswitch]
drivers/iio/adc/lmp92001-adc.c:90:3: warning: enumeration value
‘IIO_GRAVITY’ not handled in switch [-Wswitch]
>
>
>
[-- Attachment #2: Type: text/html, Size: 8508 bytes --]
next prev parent reply other threads:[~2017-08-18 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 9:12 [PATCH 2/5] iio: Add support for LMP92001 ADC s.abhisit
2017-08-01 10:10 ` Jonathan Cameron
[not found] ` <CAMV_pUaV54qUc1wOhL5cAP8mEX1k0VsL3aEGG+wziqPPnZGHWg@mail.gmail.com>
2017-08-02 7:06 ` Abhisit Sangjan
2017-08-09 14:22 ` Jonathan Cameron
2017-08-03 10:40 ` Peter Meerwald-Stadler
2017-08-05 4:49 ` Abhisit Sangjan
2017-08-11 14:38 ` jmondi
2017-08-18 2:34 ` Abhisit Sangjan
2017-08-18 2:58 ` jmondi
2017-08-18 3:15 ` Abhisit Sangjan
2017-08-18 7:42 ` Abhisit Sangjan [this message]
2017-08-20 10:31 ` Jonathan Cameron
2017-08-21 17:29 ` jmondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMV_pUaM5MAYL_R+0_9uW52fmp+c5XjBNyWeMFZqCx3MUWD59g@mail.gmail.com \
--to=s.abhisit@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=fabrice.gasnier@st.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).