From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Richard Weinberger <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
Date: Sat, 26 Mar 2016 10:05:04 +0100 [thread overview]
Message-ID: <CAMuHMdU19590PHEMbg6B7XRmMgSv2E-c96Buxy7q8x2Asykvbg@mail.gmail.com> (raw)
In-Reply-To: <1458945655-5027-1-git-send-email-richard@nod.at>
Hi Richard,
On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> base = ioremap(res.start, resource_size(&res));
> ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
I don't think that commit is the root cause ;-)
Before there were no dependencies at all...
Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb")
> Signed-off-by: Richard Weinberger <richard@nod.at>
With the above fixed:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-03-26 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 3/8] phy: Fix phy-omap-control dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
2016-03-30 8:50 ` Srinivas Kandagatla
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
2016-03-28 8:44 ` Jonathan Cameron
2016-03-25 22:40 ` [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
2016-03-28 9:03 ` Jonathan Cameron
2016-03-26 9:05 ` Geert Uytterhoeven [this message]
2016-03-26 9:27 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-30 4:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU19590PHEMbg6B7XRmMgSv2E-c96Buxy7q8x2Asykvbg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=kishon@ti.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).