From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f195.google.com ([209.85.213.195]:34335 "EHLO mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbcCZJFG convert rfc822-to-8bit (ORCPT ); Sat, 26 Mar 2016 05:05:06 -0400 MIME-Version: 1.0 In-Reply-To: <1458945655-5027-1-git-send-email-richard@nod.at> References: <1458945655-5027-1-git-send-email-richard@nod.at> Date: Sat, 26 Mar 2016 10:05:04 +0100 Message-ID: Subject: Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies From: Geert Uytterhoeven To: Richard Weinberger Cc: "linux-kernel@vger.kernel.org" , linux-iio@vger.kernel.org, Kishon Vijay Abraham I Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Hi Richard, On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger wrote: > This driver needs io memory. > > Fixes the following Kconfig warning: > warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) > > And this build error: > drivers/mfd/syscon.c: In function ‘of_syscon_register’: > drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default] > base = ioremap(res.start, resource_size(&res)); > ^ > drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(base); > > Cc: Kishon Vijay Abraham I > Cc: Geert Uytterhoeven > Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64") I don't think that commit is the root cause ;-) Before there were no dependencies at all... Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb") > Signed-off-by: Richard Weinberger With the above fixed: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds