* [PATCH] fix build error of function iio_event_getfd
@ 2011-11-26 8:07 Hui Zhu
2011-11-26 8:52 ` Cong Wang
2011-11-26 9:19 ` Jonathan Cameron
0 siblings, 2 replies; 5+ messages in thread
From: Hui Zhu @ 2011-11-26 8:07 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman, Michael Hennerich,
linux-iio, devel, linux-kernel
Got a build error:
CC [M] drivers/staging/iio/industrialio-core.o
/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:
In function =91iio_event_getfd=92:
/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:32=
:
error: =91ev_int=92 undeclared (first use in this function)
/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:32=
:
note: each undeclared identifier is reported only once for each
function it appears in
Not sure it is fixed or not.
Post a patch for it.
Signed-off-by: Hui Zhu <teawater@gmail.com>
---
drivers/staging/iio/industrialio-core.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -243,6 +243,7 @@ static const struct file_operations iio_
static int iio_event_getfd(struct iio_dev *indio_dev)
{
int fd;
+ struct iio_event_interface *ev_int =3D indio_dev->event_interface;
if (indio_dev->event_interface =3D=3D NULL)
return -ENODEV;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fix build error of function iio_event_getfd
2011-11-26 8:07 [PATCH] fix build error of function iio_event_getfd Hui Zhu
@ 2011-11-26 8:52 ` Cong Wang
2011-11-26 9:19 ` Jonathan Cameron
1 sibling, 0 replies; 5+ messages in thread
From: Cong Wang @ 2011-11-26 8:52 UTC (permalink / raw)
To: Hui Zhu
Cc: Jonathan Cameron, Greg Kroah-Hartman, Michael Hennerich,
linux-iio, devel, linux-kernel
On Sat, Nov 26, 2011 at 4:07 PM, Hui Zhu <teawater@gmail.com> wrote:
> Got a build error:
> =C2=A0CC [M] =C2=A0drivers/staging/iio/industrialio-core.o
> /home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:
> In function =E2=80=98iio_event_getfd=E2=80=99:
> /home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:=
32:
> error: =E2=80=98ev_int=E2=80=99 undeclared (first use in this function)
> /home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:=
32:
> note: each undeclared identifier is reported only once for each
> function it appears in
> Not sure it is fixed or not.
It is fixed twice...
https://lkml.org/lkml/2011/11/25/52
https://lkml.org/lkml/2011/11/23/114
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix build error of function iio_event_getfd
2011-11-26 8:07 [PATCH] fix build error of function iio_event_getfd Hui Zhu
2011-11-26 8:52 ` Cong Wang
@ 2011-11-26 9:19 ` Jonathan Cameron
2011-11-27 0:54 ` Greg KH
2011-11-27 7:01 ` Hui Zhu
1 sibling, 2 replies; 5+ messages in thread
From: Jonathan Cameron @ 2011-11-26 9:19 UTC (permalink / raw)
To: Hui Zhu, Greg Kroah-Hartman, Michael Hennerich, linux-iio, devel,
linux-kernel
Thanks but this is 7th fix I have seen.
Hui Zhu <teawater@gmail.com> wrote:
>Got a build error:
> CC [M] drivers/staging/iio/industrialio-core.o
>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:
>In function =E2=80=98iio_event_getfd=E2=80=99:
>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:2=
62:32:
>error: =E2=80=98ev_int=E2=80=99 undeclared (first use in this function=
)
>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:2=
62:32:
>note: each undeclared identifier is reported only once for each
>function it appears in
>Not sure it is fixed or not.
>Post a patch for it.
>
>Signed-off-by: Hui Zhu <teawater@gmail.com>
>---
> drivers/staging/iio/industrialio-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
>--- a/drivers/staging/iio/industrialio-core.c
>+++ b/drivers/staging/iio/industrialio-core.c
>@@ -243,6 +243,7 @@ static const struct file_operations iio_
> static int iio_event_getfd(struct iio_dev *indio_dev)
> {
> int fd;
>+ struct iio_event_interface *ev_int =3D indio_dev->event_interface;
>
> if (indio_dev->event_interface =3D=3D NULL)
> return -ENODEV;
--=20
Sent from my Android phone=20
with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fix build error of function iio_event_getfd
2011-11-26 9:19 ` Jonathan Cameron
@ 2011-11-27 0:54 ` Greg KH
2011-11-27 7:01 ` Hui Zhu
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2011-11-27 0:54 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hui Zhu, Greg Kroah-Hartman, Michael Hennerich, linux-iio, devel,
linux-kernel
On Sat, Nov 26, 2011 at 09:19:34AM +0000, Jonathan Cameron wrote:
> Thanks but this is 7th fix I have seen.
And I sent an 8th one to Linus now, that's a bit smaller :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix build error of function iio_event_getfd
2011-11-26 9:19 ` Jonathan Cameron
2011-11-27 0:54 ` Greg KH
@ 2011-11-27 7:01 ` Hui Zhu
1 sibling, 0 replies; 5+ messages in thread
From: Hui Zhu @ 2011-11-27 7:01 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Michael Hennerich, linux-iio, devel,
linux-kernel, Amerigo Wang
On Sat, Nov 26, 2011 at 17:19, Jonathan Cameron <jic23@cam.ac.uk> wrote:
> Thanks but this is 7th fix I have seen.
Cool! I am in the top 10. :)
Sorry for disturb you.
Thanks,
Hui
>
> Hui Zhu <teawater@gmail.com> wrote:
>
>>Got a build error:
>> =A0CC [M] =A0drivers/staging/iio/industrialio-core.o
>>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:
>>In function =91iio_event_getfd=92:
>>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:=
32:
>>error: =91ev_int=92 undeclared (first use in this function)
>>/home/teawater/kernel2/linux/drivers/staging/iio/industrialio-core.c:262:=
32:
>>note: each undeclared identifier is reported only once for each
>>function it appears in
>>Not sure it is fixed or not.
>>Post a patch for it.
>>
>>Signed-off-by: Hui Zhu <teawater@gmail.com>
>>---
>> drivers/staging/iio/industrialio-core.c | =A0 =A01 +
>> 1 file changed, 1 insertion(+)
>>
>>--- a/drivers/staging/iio/industrialio-core.c
>>+++ b/drivers/staging/iio/industrialio-core.c
>>@@ -243,6 +243,7 @@ static const struct file_operations iio_
>> static int iio_event_getfd(struct iio_dev *indio_dev)
>> {
>> =A0 =A0 =A0 int fd;
>>+ =A0 =A0 =A0struct iio_event_interface *ev_int =3D indio_dev->event_inte=
rface;
>>
>> =A0 =A0 =A0 if (indio_dev->event_interface =3D=3D NULL)
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENODEV;
>
> --
> Sent from my Android phone
> with K-9 Mail. Please excuse my brevity.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-27 7:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-26 8:07 [PATCH] fix build error of function iio_event_getfd Hui Zhu
2011-11-26 8:52 ` Cong Wang
2011-11-26 9:19 ` Jonathan Cameron
2011-11-27 0:54 ` Greg KH
2011-11-27 7:01 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).