From: Otavio Salvador <otavio@ossystems.com.br>
To: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v10] Add Microchip MCP3422/3/4 high resolution ADC
Date: Wed, 20 Nov 2013 00:24:41 -0200 [thread overview]
Message-ID: <CAP9ODKoX_ozDo0CGMSQZPMBFhOEZfrYnm2esySViMCFtGE1Q1w@mail.gmail.com> (raw)
In-Reply-To: <1378130401-22367-1-git-send-email-angelo.compagnucci@gmail.com>
On Mon, Sep 2, 2013 at 11:00 AM, Angelo Compagnucci
<angelo.compagnucci@gmail.com> wrote:
> Kawabonga! It works! Really, but really (no joke here!) thank you
> for your precious support and sorry for not being so smart to
> understand what you were saying me. Sorry again for being so pedantic!
>
> I'm planning to write a tutorial based on my journey, something like
> "Howto write your first IIO LDD", what do you think?
>
> Attached here, there is the latest version of the patch based on jour suggestions.
> I think all of your concerns are solved now.
>
> Thank you again!
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
...
> +static const struct i2c_device_id mcp3422_id[] = {
> + { "mcp3422", 2 },
> + { "mcp3423", 3 },
> + { "mcp3424", 4 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, mcp3422_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id mcp3422_of_match[] = {
> + { .compatible = "mcp3422" },
> + { }
Shouldn't this be mcp,mcp3422?
Another question, are you aware of need changes to use with mcp3428?
Otherwise I will look at this.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2013-11-20 2:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 14:00 [PATCH v10] Add Microchip MCP3422/3/4 high resolution ADC Angelo Compagnucci
2013-09-07 21:20 ` Jonathan Cameron
2013-09-07 21:25 ` Jonathan Cameron
2013-11-20 2:24 ` Otavio Salvador [this message]
2013-11-20 10:24 ` Angelo Compagnucci
2013-11-20 10:46 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9ODKoX_ozDo0CGMSQZPMBFhOEZfrYnm2esySViMCFtGE1Q1w@mail.gmail.com \
--to=otavio@ossystems.com.br \
--cc=angelo.compagnucci@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).