From: Giuseppe Barba <giuseppe.barba@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Denis Ciocca <denis.ciocca@st.com>,
Giuseppe BARBA <giuseppe.barba@st.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH] iio: st: rework code style removing goto statements
Date: Tue, 21 Jul 2015 14:14:10 +0200 [thread overview]
Message-ID: <CAPMRSisPJxrDaXmX8DcQpYsw0Z3LLmD+msaYLX7a7Zoy-JgDfQ@mail.gmail.com> (raw)
In-Reply-To: <CAEnQRZC7z3ZbR40xnG2UPmVVJ34at8mKS70R5O9h24HNAKQZbQ@mail.gmail.com>
Hi Daniel,
2015-07-21 13:23 GMT+02:00 Daniel Baluta <daniel.baluta@gmail.com>:
> On Tue, Jul 21, 2015 at 2:08 PM, Giuseppe Barba
> <giuseppe.barba@gmail.com> wrote:
>> Hi Denis,
>>
>> thanks for review.
>>>
>>> Just add one blank line please, it was missing also before!
>>>
>>> Denis
>>
>> I'll add the missed blank line and push again the patch to you.
>
> Hi Giuseppe,
>
> Thanks a lot for your work :). One minor nit that could improve
> reviews for your next patches.
>
> Please add modification history from version to version. This can be done
> in the cover letter if you have multiple patches, or in the patch itself under
> the scissor line.
>
> e.g.
> [PATCH V2] iio: st: rework code style removing goto statements
>
> The scope of this patch is to remove some goto statements and its label
> present into st sensors driver.
>
> Signed-off-by: Giuseppe Barba <giuseppe.barba@st.com>
> --- <this is scissor line>
> Change since v1:
> * added missing blank lines.
>
> thanks,
> Daniel.
Thanks for your hint.
I'll do that next time.
Regards
Giuseppe.
prev parent reply other threads:[~2015-07-21 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 10:14 [PATCH] iio: st: rework code style removing goto statements Giuseppe Barba
2015-07-21 11:00 ` Denis Ciocca
2015-07-21 11:08 ` Giuseppe Barba
2015-07-21 11:23 ` Daniel Baluta
2015-07-21 12:14 ` Giuseppe Barba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPMRSisPJxrDaXmX8DcQpYsw0Z3LLmD+msaYLX7a7Zoy-JgDfQ@mail.gmail.com \
--to=giuseppe.barba@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=denis.ciocca@st.com \
--cc=giuseppe.barba@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).