From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02043C41513 for ; Mon, 16 Oct 2023 13:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232355AbjJPNxs (ORCPT ); Mon, 16 Oct 2023 09:53:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbjJPNxs (ORCPT ); Mon, 16 Oct 2023 09:53:48 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4626DF0 for ; Mon, 16 Oct 2023 06:53:46 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-53ebf429b4fso2024464a12.1 for ; Mon, 16 Oct 2023 06:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1697464425; x=1698069225; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vOvRSIBCKDO/EoG06SNXpskpBSv5uHfI6z7Qbijhh84=; b=ZGfXHDIEVPsrSdi6s+cmpqGpouYUKTMnHCS0XjgyskuNwWucIDjhMF7sJdA650u0aF F6LffFSACGmJSI0ChVpnRRmsvDqaSedds+h4Pq2bhnEXceocq6j1uKfCv5VZk5GxK8LQ QGlBpWwk0qLq3vPnL4ILlwUdvrCcYNkzABzYzs1HEiKVKwYFehlXmDnkLhGVla1K6qq/ 5Dpoa8QwjjfdotnmCzsEhOl7rplTtfTMuEPnT6YtISlME/pEkSdm5bxTXeoB7YeiOgHN TGDg77JFPEL7UTIhgBoRUTcVz+P0KCmntScaYclCQVXVL3ZqPWrlU5GndpHBd/CXgr9e Hq7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697464425; x=1698069225; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vOvRSIBCKDO/EoG06SNXpskpBSv5uHfI6z7Qbijhh84=; b=HceUR4SasiuQ4MZ+0asK19WigIC3Ep0jvs7o3cqDLz2qTA3ANkdd6KSUyMA+i8H+7n fzl0v7ASgthm63auIe3JmT5JuPiBMuvziwxhk8OGRFvTOiTzoNhBV5Q/Ty2V4CUn7D3G gDD53U1ZzAmsIeXmPDrtN2rSD2d267fmZUYIxpUX2daBkHftHkllNebZk2vcboaH/noD 2yR8lcK81NnPDt8cQ/0oo1owYWZ5QyTxn0G1LAQJ25tS2fssqhHqTrq8sJzzQJuEbQ/d VZBSuuHyFM29vDEdgWaAkq0O+3LA6nwMQQh+K1v9g/Foinuc5EbFNs9QzriwqCoKQDaa I2lg== X-Gm-Message-State: AOJu0YyqkVXJJgNjZ+2OEVmUYixb/cIbADh23T0iMoWF0duJBjJZfmck UuVbkeMsSrS83hxQdp4DTKSz6w== X-Google-Smtp-Source: AGHT+IHoxPW8PwdZUvfviYS7QdbDikx9yohEhHLS/XOTq3T9uH87ZFiSCdLJimiupbVDzkcfzqrchA== X-Received: by 2002:aa7:c549:0:b0:525:6e47:10f6 with SMTP id s9-20020aa7c549000000b005256e4710f6mr29895269edr.22.1697464424717; Mon, 16 Oct 2023 06:53:44 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id q18-20020a50c352000000b0053e9352643csm3015296edb.62.2023.10.16.06.53.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 06:53:43 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Oct 2023 15:53:42 +0200 Message-Id: Cc: , , , , "Rob" , "Clayton Craft" , <~postmarketos/upstreaming@lists.sr.ht> Subject: Re: [PATCH 1/5] iio: adc: add smb139x bindings From: "Luca Weiss" To: "Nia Espera" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Kees Cook" , "Tony Luck" , "Guilherme G. Piccoli" X-Mailer: aerc 0.15.2 References: <20231016-nia-sm8350-for-upstream-v1-0-bb557a0af2e9@igalia.com> <20231016-nia-sm8350-for-upstream-v1-1-bb557a0af2e9@igalia.com> In-Reply-To: <20231016-nia-sm8350-for-upstream-v1-1-bb557a0af2e9@igalia.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon Oct 16, 2023 at 2:47 PM CEST, Nia Espera wrote: > Bindings for a charger controller chip found on sm8350 > > Signed-off-by: Nia Espera > --- > include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h b/include/d= t-bindings/iio/qcom,spmi-adc7-smb139x.h > new file mode 100644 > index 000000000000..fe163cd8bbdd > --- /dev/null > +++ b/include/dt-bindings/iio/qcom,spmi-adc7-smb139x.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2020 The Linux Foundation. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_QCOM_SPMI_VADC_SMB139X_H > +#define _DT_BINDINGS_QCOM_SPMI_VADC_SMB139X_H > + > +#define SMB139x_1_ADC7_SMB_TEMP (SMB139x_1_SID << 8 | 0x06) > +#define SMB139x_1_ADC7_ICHG_SMB (SMB139x_1_SID << 8 | 0x18) > +#define SMB139x_1_ADC7_IIN_SMB (SMB139x_1_SID << 8 | 0x19) > + > +#define SMB139x_2_ADC7_SMB_TEMP (SMB139x_2_SID << 8 | 0x06) > +#define SMB139x_2_ADC7_ICHG_SMB (SMB139x_2_SID << 8 | 0x18) > +#define SMB139x_2_ADC7_IIN_SMB (SMB139x_2_SID << 8 | 0x19) I think you should expand qcom,spmi-vadc.h with the 0x06, 0x18 and 0x19, in the ADC7 defines somewhere below ADC7_REF_GND. Regards Luca > + > +#endif