Re: [PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

Chukun Pan
2024-08-25T14:26:41Z

Hi,

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> ...
> + leds: leds {
> + compatible = "gpio-leds";

Maybe there should be a blank line.

> + work_led: work-led {
> + gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };

Is the color missing?

> ...
> + vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_3v3_rtc_s5";
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vcc_5v0_sys>;
> + };

Missing blank line.

> + vcc_1v8_s0: regulator-vcc-1v8-s0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_1v8_s0";
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vcc_1v8_s3>;
> + };
> ...
> +&gmac0 {
> + phy-mode = "rgmii-rxid";

Can we use "rgmii-id" and remove tx_delay here?

> ...
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
> + disable-wp;
> + max-frequency = <200000000>;
> + no-sdio;
> + no-mmc;
> + non-removable;
> + sd-uhs-sdr104;
> + vmmc-supply = <&vcc_3v3_s3>;

Indentation error.

> + vqmmc-supply = <&vccio_sd_s0>;
> + status = "okay";
> +};
> ...

Thanks,
Chukun

--
2.25.1