Re: [PATCH v2 1/4] iio: gts-helper: add helpers to ease searches of gain_sel and new_gain

["Javier Carrasco" <javier.carrasco.cruz@gmail.com>]

On Sat Dec 28, 2024 at 4:41 PM CET, Jonathan Cameron wrote:
> On Tue, 24 Dec 2024 11:59:00 +0100
> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
>
> > This helper functions reduce the burden in the drivers that want to
> > fetch a gain selector in all available times or a new optimal gain.
> >
> > The former is currently achieved by calling
> > iio_gts_find_gain_sel_for_scale_using_time() for the current time
> > selector, and then iterating over the rest of time selectors if the
> > gain selector was not found.
> >
> > The latter requires a combination of multiple iio-gts helpers to find
> > the new gain, look for an optimal gain if there was no exact match, and
> > set a minimum gain if the optimal gain is not in the range of available
> > gains.
> >
> > Provide simpler workflows by means of functions that address common
> > patterns in the users of the iio-gts helpers.
> >
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> Matti gave an Ack.   If you intentionally dropped it due to significant
> changes, you should say so...
>
> > ---
>
> here.
>
> Other than that, looks fine to me.
>
> Jonathan

Hi Jonathan, you are absolutely right.

I did not add the Ack on purpose because I thought that I had to modify
the helpers functions, but in the end that was not the case. Matti's tag
should have stayed.

Best regards,
Javier Carrasco