From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D311B21C194 for ; Fri, 29 Aug 2025 20:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756499426; cv=none; b=gqdRouJCHs9iq46qyemLg71F3LMWTXv59DG1jfuqL7MBf1ixU7kmrq9EYXv8OpnZ2zKnQ7y1JNDE1m2a0dqIIr8owAvqc2tiTgizP0t/fmK33h9v28VR1tMXvycd66SwWx0N+P0wBNXAlPM3/x4Oq7yWEvFtYWWOPD6751EPdVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756499426; c=relaxed/simple; bh=SJivwaFIMN9pzc/GzyVi63H3VG5P90Cy+u+DLytb+Y0=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:To:From: References:In-Reply-To; b=oHuKztQuZaB8v0Jjfp+FzCp5Lp1OV6QYHnksXkD71quuhySZPpHhtwRRCQUbMqJa/r9qHmOcKHpqWvgCo1FpxcaZXgSp7goEf67nhFOOkNPXgornm04mx6rLyB/f4XGLr7yQBW5MFhAf0Ez1ciTk3W+a+GXL8WEjf/xWiwXeLME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b=LhiyRWoe; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mff.cuni.cz header.i=@mff.cuni.cz header.b="LhiyRWoe" X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mff.cuni.cz; s=submission; t=1756499411; x=1757799411; bh=DvTREl3RPMtyVXWwp9xdMSUcqBDVOu5mAI1D2OmkO9w=; h=From; b=LhiyRWoeU46kPZAZU1Kp04Be4TjynW7S6Brz4wrTrUCwoI3+xx6A11UkZn4YcQ5tg eyZP5Kwyh+I1pTAQZFPQm8WRUgXJ+qM6GRxsz/XS5/b8WVF2fnsApJdX+KoC/4x0ug kd7PWptpePabIyDDkN/SkxS9pJ9YfEV1MALgTGOe3GX/xW/ou/+FSPTkvDoWneAJiD cagjPl76NbbKcF/z04/35NuYMLsFvkLLLa5abWXkAt5CSSyh4S+QXWtU79LGc+eI9h B/BU67Hv7dTRsRHOR+hURIY04hTBl3smzAHkGmL8IeJrfFrIFVCuKYjPWFTv4Ds8D+ jCqCrg2wkCwWQ== Received: from localhost (internet5.mraknet.com [185.200.108.250]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 57TKU90L021409 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Fri, 29 Aug 2025 22:30:11 +0200 (CEST) (envelope-from balejk@matfyz.cz) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 29 Aug 2025 22:30:09 +0200 Message-Id: Cc: "Jonathan Cameron" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Lee Jones" , "David Wronek" , , <~postmarketos/upstreaming@lists.sr.ht>, , Subject: Re: [PATCH 2/2] mfd: 88pm886: Add GPADC cell To: "Andy Shevchenko" , =?utf-8?q?Duje_Mihanovi=C4=87?= From: "Karel Balej" References: <20250829-88pm886-gpadc-v1-0-f60262266fea@dujemihanovic.xyz> <20250829-88pm886-gpadc-v1-2-f60262266fea@dujemihanovic.xyz> In-Reply-To: Andy Shevchenko, 2025-08-29T18:47:19+03:00: > On Fri, Aug 29, 2025 at 1:18=E2=80=AFAM Duje Mihanovi=C4=87 wrote: >> >> Add a cell for the PMIC's onboard General Purpose ADC. > > ... > >> static const struct mfd_cell pm886_devs[] =3D { > >> MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources), >> MFD_CELL_NAME("88pm886-regulator"), >> MFD_CELL_NAME("88pm886-rtc"), >> + MFD_CELL_NAME("88pm886-gpadc"), > > List seems ordered, please prevent it. Ah, I never explicitly realized to keep it ordered, seems like I was just lucky to implement the components in the right order :-) Anyway, yes, please keep it ordered. When you fix that, you may add Acked-by: Karel Balej # for the PMIC Thanks, K. B.