From: "Karel Balej" <balejk@matfyz.cz>
To: "Duje Mihanović" <duje@dujemihanovic.xyz>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Lee Jones" <lee@kernel.org>,
"David Wronek" <david@mainlining.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC
Date: Fri, 29 Aug 2025 22:38:57 +0200 [thread overview]
Message-ID: <DCF79FFP6NJS.J73DD94U1ZNK@matfyz.cz> (raw)
In-Reply-To: <2453108.NG923GbCHz@radijator>
Duje Mihanović, 2025-08-29T19:40:41+02:00:
> On Friday, 29 August 2025 18:27:30 Central European Summer Time Jonathan Cameron wrote:
>> On Fri, 29 Aug 2025 00:17:41 +0200
>>
>> Duje Mihanović <duje@dujemihanovic.xyz> wrote:
>> > + iio->name = "88pm886-gpadc";
>> > + iio->dev.parent = dev;
>> > + iio->dev.of_node = parent->of_node;
>>
>> Done in core code.
>> https://elixir.bootlin.com/linux/v6.16.3/source/drivers/iio/industrialio-core.
>> c#L2044 __iio_device_register() so unless you use it before that call
>> shouldn't need this.
>>
>> I'm not sure what it is used for though.
>
> It was to explicitly bind the ADC (specifically, its IO channels) to
> the PMIC devicetree node. However, since the core does this already,
> will drop.
I believe the PMIC binding should probably be updated with the
#io-channel-cells property then, isn't that so?
next prev parent reply other threads:[~2025-08-29 20:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 22:17 [PATCH 0/2] Marvell 88PM886 PMIC GPADC driver Duje Mihanović
2025-08-28 22:17 ` [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC Duje Mihanović
2025-08-28 23:40 ` David Lechner
2025-08-29 15:20 ` Duje Mihanović
2025-08-29 15:52 ` David Lechner
2025-08-30 4:37 ` Andy Shevchenko
2025-08-30 4:41 ` Andy Shevchenko
2025-08-30 13:07 ` Duje Mihanović
2025-08-30 15:05 ` Andy Shevchenko
2025-08-30 19:41 ` Jonathan Cameron
2025-08-30 13:03 ` Duje Mihanović
2025-08-30 14:53 ` Andy Shevchenko
2025-08-30 16:29 ` Duje Mihanović
2025-08-29 16:27 ` Jonathan Cameron
2025-08-29 17:40 ` Duje Mihanović
2025-08-29 20:38 ` Karel Balej [this message]
2025-08-28 22:17 ` [PATCH 2/2] mfd: 88pm886: Add GPADC cell Duje Mihanović
2025-08-29 15:47 ` Andy Shevchenko
2025-08-29 20:30 ` Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCF79FFP6NJS.J73DD94U1ZNK@matfyz.cz \
--to=balejk@matfyz.cz \
--cc=andy@kernel.org \
--cc=david@mainlining.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox