Re: [PATCH v5 0/7] iio: core: Introduce cleanup.h support for mode locks

Kurt Borja
2026-01-22T22:27:32Z

On Thu Jan 22, 2026 at 2:16 PM -05, Jonathan Cameron wrote:
> On Tue, 20 Jan 2026 01:20:40 -0500
> Kurt Borja <kuurtb@gmail.com> wrote:
>
>> Hi,
>>
>> In a recent driver review discussion [1], Andy Shevchenko suggested we
>> add cleanup.h support for the lock API:
>>
>> iio_device_claim_{direct,buffer_mode}().
>>
>> Which would allow some nice code simplification in many places. Some
>> examples are given as patches, but the last two are the biggest
>> differences.
>>
>> In this version I dropped the RFC tag, as the general feeling is to go
>> through with this after some modifications. Main one is the addition of
>> IIO_DEV_ACQUIRE_{BUFFER,CLAIM}_MODE() wrappers to avoid drivers using
>> the guard classes directly. I also added comments on the forbidden ways
>> to use this API but I definitely still take suggestions on this.
>>
>> For now I dropped iio_device_claim_buffer_mode() rename, as this point
>> is still being discussed. My suggestion based on the RFC discussion is
>> to do it, but in a separate patch (using coccinelle) and while we're at
>> it rename the whole API like this:
>>
>> iio_dev_mode_lock()
>> iio_dev_mode_direct_trylock()
>> iio_dev_mode_buffer_trylock()
>> iio_dev_mode_unlock()
>>
>> Let me know what you think and thanks for taking a look!
>>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> I've queued this up. For now it'll just be pushed out on the testing branch.
> Hopefully the new noise from sparse won't bother anyone too much.
>
> Jonathan

Thank you for all the feedback!

I'll try to keep an eye on the lists in case of automatic reports.

--
Thanks,
~ Kurt