From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: light: gp2ap020a00f: Correct return type to int
Date: Sat, 14 Feb 2026 13:25:07 -0600 [thread overview]
Message-ID: <DGEXIYVWABUD.2RSBMFJHUGAIY@gmail.com> (raw)
In-Reply-To: <20260214190829.018b057e@jic23-huawei>
On Sat Feb 14, 2026 at 1:08 PM CST, Jonathan Cameron wrote:
> On Tue, 10 Feb 2026 18:48:19 -0600
> Ethan Tidmore <ethantidmore06@gmail.com> wrote:
...
> Did you find a path via which it can actually return an error? char
> and dir are tightly constrained inputs.
>
> I think the error return is probably just defensive coding against future bugs
> and compiler warning supression.
Yes you're right. I was just correcting a signness warning from smatch
and just added the extra checks.
>
> If so it's still a good thing to clean up but Fixes tag and backports
> probably not appropriate.
>
> And best of all, once it's not a fix we can use some guard()
> magic to make these functions and your new checks cleaner.
> guard() usage would be a precursor patch with this one on top to minimize
> churn.
I'll send a series adding these checks and using guard() and will drop
the Fixes: tag.
Thanks,
ET
prev parent reply other threads:[~2026-02-14 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 0:48 [PATCH] iio: light: gp2ap020a00f: Correct return type to int Ethan Tidmore
2026-02-11 8:44 ` Andy Shevchenko
2026-02-14 19:08 ` Jonathan Cameron
2026-02-14 19:25 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGEXIYVWABUD.2RSBMFJHUGAIY@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox