public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "Ethan Tidmore" <ethantidmore06@gmail.com>, <andy@kernel.org>,
	<linux-iio@vger.kernel.org>
Subject: Re: [RFC] GSoC 2026: Transitioning IIO to guard() and scoped_guard()
Date: Sat, 14 Mar 2026 13:08:04 -0500	[thread overview]
Message-ID: <DH2PF86XN60W.2MVDUHLKPR7LH@gmail.com> (raw)
In-Reply-To: <20260314110758.2fc20704@jic23-huawei>

On Sat Mar 14, 2026 at 6:07 AM CDT, Jonathan Cameron wrote:
> On Wed, 11 Mar 2026 22:18:07 +0200

...

>
> Hi Ethan
>
> I'm not keen on a mass cleanup like this without taking a closer look at
> the drivers. I would say (based on gut feeling rather than actually
> having checked the stats) that perhaps 25% of these patches result in
> feedback on the surrounding code or follow on improvements that are
> enabled. 

That makes sense. That would be a ton of time spent on reviewing this.

...

> As to the your question on how this 'might' be done, it would need to be
> 1 patch per driver because this will cause chaos for backports of later
> fixes due to significant churn.

Yeah, that kills the idea entirely. I was hoping it could be done per
vendor per dir but, I understand why that wouldn't work.

>
> There are ABI changes that we want to push through the tree such
> as iio_push_to_buffers_with_ts() but that's because the new ABI
> is inherently safer and I want to get rid of the old one.
> Some of those cases are easy, others much less so.

If a tree wide conversion to iio_push_to_buffers_with_ts() would be
wanted I'd be glad to do that. There is much less volume for this
project and if completed then a deprecated function could be removed.

$ grep -rn "iio_push_to_buffers_with_timestamp" drivers/iio/ | wc -l
73

And this would be much more manageable to review. Would this be a viable
proposal for GsoC?

Thanks,

ET

  reply	other threads:[~2026-03-14 18:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 19:46 [RFC] GSoC 2026: Transitioning IIO to guard() and scoped_guard() Ethan Tidmore
2026-03-11 20:18 ` Andy Shevchenko
2026-03-14 11:07   ` Jonathan Cameron
2026-03-14 18:08     ` Ethan Tidmore [this message]
2026-03-15 18:34       ` David Lechner
2026-03-15 19:01         ` Jonathan Cameron
2026-03-15 18:41       ` Jonathan Cameron
2026-03-16  1:11         ` Ethan Tidmore
2026-03-18  1:28           ` Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH2PF86XN60W.2MVDUHLKPR7LH@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox