Re: [PATCH] staging: iio: ad9834: fix probe error handling and comment typo

["Maxwell Doose" <m32285159@gmail.com>]

Hi Angus,

On Fri May 1, 2026 at 9:18 PM CDT, Angus Gardner <angusg778@gmail.com> wrote:
> Use dev_err_probe() for the master clock error path instead of open-coding
> dev_err() + PTR_ERR(), consistent with the avdd regulator error path above
> it and with the equivalent driver ad9832.c.
>
> Simplify the -ENOMEM return after devm_iio_device_alloc() to a direct
> return rather than bouncing through a local variable.
>
> Fix a copy-paste typo in two comments that referred to 'AD9843' instead
> of the correct chip name 'AD9834'.
>
> Signed-off-by: Angus Gardner <angusg778@gmail.com>
> ---
>  drivers/staging/iio/frequency/ad9834.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
>

Patch itself looks good but maybe rephrase subject to say "Use probe
error handling and fix comment typo" instead? "Fix" seems a bit generic
for my tastes, and we're not really fixing anything anyways.

I'm not the final authority on naming so its at the discretion of
either Andy or Jonathan, and maybe Greg. So either way,
Reviewed-by: Maxwell Doose <m32285159@gmail.com>

best regards,
maxwell