From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DEF23921D0 for ; Wed, 13 May 2026 18:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696602; cv=none; b=M37IS1zr+EeR9mITGH1H3C7zZ5BE9jeOC397pwEZgukRV48rY6a+uBaIxKHSTk2CDx55w9+BRTsDmbbmowldzx1ZJWFyjC5qsJJQ+pp+vYiuJ+90kCPlbmo/qggEUM0aOkv392gO4wDMU6J+oRiN7bnutZtlgaudie2Wh5sChrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696602; c=relaxed/simple; bh=dOfXhl/3ROZBdvGUuq5lc6pP2skpMQ+Impsv7uUwQSg=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=hQ5KeQ33d8wdkmSDz6mIVpuDDhbtp2tEZP0d20lZ57QiQ6lYSRfOAmBxjiLlUtsz3eNa8UXtkZev3OpPbgH4pX2Juzx5FrT0/aMbHqNZuDzRYwKkT8TUHY3jqiyXqdCjX/EO5MCV1/Vr1zeUjl+uvR4TNdzujYx1VUtpExfN1AM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lGtoa+Vb; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lGtoa+Vb" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-83945063f70so3869809b3a.0 for ; Wed, 13 May 2026 11:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778696601; x=1779301401; darn=vger.kernel.org; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W8tquXezPQtGk+rIcg/OfsmqPD3duQcZyQFMnO23FMw=; b=lGtoa+Vbbauh4mqRm2G1+N9R2bNFDX24LP1V56Pw4mCNdBJXgxlTM/JatzqrY+YQ7B p5B1oSiohmBvipxS7HPc1I2w0LzBpRiKh/MTcynFAkIG/ja6jNm2vZN6wAZf5Ie/mTic SiWeH7CxtDt11l9GiogwuC/gDSeKMU0fuQYP11ciXgG0kqWDR/t/w6F4Ck7oKBgSBod+ 2WqTUd+wkXjTtdcG4IoDj+NA/eytQf1iJKEi2OgzOzU18CI7QYQHBMc30W5BAM8Vu1IW o9d5UdQd6Uz/0UN98XrsaDyXFERjW75xXCk7EQRhobRpYjFMOsT7bKuYbIuxmiTmus5k 9n+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778696601; x=1779301401; h=in-reply-to:references:cc:subject:from:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=W8tquXezPQtGk+rIcg/OfsmqPD3duQcZyQFMnO23FMw=; b=C3p4U9fbOWSqlOsdWG6nd4cllZEq1RyokEcJ75VltD1RGzjja6CrDrkvc6Z9LJzlhc y4DN8wzClFNTWyOpeLe7UjYmZfdQ9juf4ASMnEhW/rXkVgk4H4AorjhsKXYX/2NcGltO UDbRIoHw7KeG9WxQJxYhMapwuHJwdoFmF1ejszYoyG/9GGvTrXwiOScx0Y0dl3DJG/qf wn5UyI8eglk3QY7GUwu4SYPmHZ/YiAVXUxQy2ix8jFMzI3dTPFw4lh/ULZKE3htHg28Z z1NrydDioBzfi8g4Y/Y3yG536ihlafV//qX/Z9GZf8ZQrHcPBAnJMJsV9wyKVfrvQT5W WgjA== X-Forwarded-Encrypted: i=1; AFNElJ/zzSmzN43P5/IHCT40KZIBSJt8QpmAC9MpaQ2f6+ZQAhDA8kFAqIV/zbX7+m/CX6PUAAfPknDSVEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8tKokqe9lytfTHnV3HG9z+ni53OW5KmujQbOBLYrwy29B1Fl6 oBkg8mVTiRIvITlyo+7J3UXGQQAdZpKHnwTjsLcEw/g99jqV0T5Depmr X-Gm-Gg: Acq92OEY2hK0mh9BTcNixvcOFjLnskT1qBONekKTQ2QQwG8h6AqIVtVtNJlB1+Vam9n FhI4W2TXXQNmSPvzxW62xeVM7V/66XhDNQOWO4qtltinBtAHGVIi12cF2KHEVncsCLtXCmSlrf2 R7lpBP+6r2I7s9N9MgtiUNPiblSrnqg+MnmLPOxOrBNjkUS1dag9w7f0h8K0YSKe1pAvntvX7VO 4ZoF56dal7STOitlBkCtOPoXCHKq4grbIq/bqmo0bjoeDscOh3nd7oQscQ6MUJnccTkjGfactkd Oi2qCBgFuvb+Ps8G4hrtWd6GsCu4DoZtghy1QeX4HkwHYqJH2d+yQI4LkQQzCb3JPB481fxOK2O vVAw2opdIm8m/U1NSiiNH7QUVDSIMQ3YqoAZT1b5wdIZ2QN+MHeMPHwILEiJT5HXZSCdumWidBh iIRqacMdO8XtO2YBysAHlWfMUV2YE5BA/4Ew== X-Received: by 2002:a05:6a00:1406:b0:837:42a6:58a2 with SMTP id d2e1a72fcca58-83f18ef9d1fmr495822b3a.35.1778696600619; Wed, 13 May 2026 11:23:20 -0700 (PDT) Received: from localhost ([203.99.159.235]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19663ff8sm209924b3a.8.2026.05.13.11.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 11:23:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 14 May 2026 07:23:10 +1300 Message-Id: To: "Andy Shevchenko" From: "Javier Carrasco" Subject: Re: [PATCH v2 4/4] iio: light: add support for veml6031x00 ALS series Cc: "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rishi Gupta" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Matti Vaittinen" , , , X-Mailer: aerc 0.20.1-4-g02324e9d9cab References: <20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com> <20260513-veml6031x00-v2-4-4703ca661a1d@gmail.com> In-Reply-To: On Thu May 14, 2026 at 5:56 AM +13, Andy Shevchenko wrote: > On Wed, May 13, 2026 at 05:49:44PM +1300, Javier Carrasco wrote: >> These sensors provide two light channels (ALS and IR), I2C communication >> and a multiplexed interrupt line to signal data ready and configurable >> threshold alarms. > > Can you split this to two or more patches: > - basic functionality > - feature 1 (exempli gratia, IR) > - feature 2 (exempli gratia, multiplexed interrupt) > - ... > > ? Yes, I can. I will wait for more feedback before proceeding. > > But let's wait for Sashiko if it swallows this big slice of the pie > and not choke on it. > > ... > >> + { >> + .compatible =3D "vishay,veml6031x01", >> + .data =3D &veml6031x01_chip, >> + }, >> + { >> + .compatible =3D "vishay,veml60311x00", >> + .data =3D &veml60311x00_chip, >> + }, >> + { >> + .compatible =3D "vishay,veml60311x01", >> + .data =3D &veml60311x01_chip, >> + }, > > Oh, is 'x' is a real letter in the part number or a wildcard? If the latt= er, > please avoid. Choose the base part number instead. > I mentioned that in the cover letter: the x belongs to the names in the datasheets and every part number. > ... > >> +static const struct i2c_device_id veml6031x00_id[] =3D { >> + { "veml6031x00", (kernel_ulong_t)&veml6031x00_chip }, >> + { "veml6031x01", (kernel_ulong_t)&veml6031x01_chip }, >> + { "veml60311x00", (kernel_ulong_t)&veml60311x00_chip }, >> + { "veml60311x01", (kernel_ulong_t)&veml60311x01_chip }, >> + { } >> +}; > > Perhaps use C99 initialisers, as there is an activity to change all drive= rs to > follow that. Jonathan, btw, what do you think we should do in the light o= f Uwe's > approach? Require C99 initialisers in new code, or something else? I will account for that in v3 alongside any other suggestions that might still arise, thank you. Best regards, Javier