Linux IIO development
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "David Lechner" <dlechner@baylibre.com>,
	"Kurt Borja" <kuurtb@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] dt-bindings: iio: adc: Add burn-out current properties
Date: Sun, 21 Jun 2026 18:43:55 -0500	[thread overview]
Message-ID: <DJF4KBA0LX3K.Q3XDAO3J1HMP@gmail.com> (raw)
In-Reply-To: <38c5e5eb-2113-4a5c-ad14-348dc7966a1c@baylibre.com>

Hi David,

On Sat Jun 20, 2026 at 10:57 AM -05, David Lechner wrote:
> On 6/19/26 11:46 AM, Kurt Borja wrote:
>> On Fri Jun 19, 2026 at 9:28 AM -05, David Lechner wrote:
>>> On 6/18/26 7:33 PM, Kurt Borja wrote:
>>>> Some ADCs incorporate burn-out current sources that provide current to
>>>> the channel's input pins for open-circuit or short-circuit detection.
>>>>
>>>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/iio/adc/adc.yaml | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
>>>> index 106b1e317411d5..6b63aac9ac04dd 100644
>>>> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
>>>> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
>>>> @@ -106,6 +106,20 @@ properties:
>>>>        This array describes the current configuration of the excitation current
>>>>        sources or the single matched current for all sources.
>>>>  
>>>> +  burn-out-current-microamp:
>>>> +    description:
>>>> +      Burn-out current sources provide current to the channel's input pins for
>>>> +      open-circuit or short-circuit detection.
>>>> +
>>>> +  burn-out-current-polarity:
>>>> +    $ref: /schemas/types.yaml#/definitions/string
>>>> +    description:
>>>> +      Burn-out current sources provide current to the channel's input pins for
>>>> +      open-circuit or short-circuit detection.
>>>> +    enum:
>>>> +      - pull-up
>>>> +      - pull-down
>>>> +
>>>>  anyOf:
>>>>    - oneOf:
>>>>        - required:
>>>>
>>>
>>> This doesn't really work with chips that just have and enable bit to
>>> enable or disable the feature.
>> 
>> Maybe those devices can use burn-out-current-microamp with a const
>> value? Is that okay or should another approach be taken?
>> 
>
> Maybe better to just leave this one out of the common file?

IMO burn-out-current-microamp would be nice to have. I don't know how
common it is for bindings to describe this kind of properties with a
single const value though.

On the other hand I do think we should drop burn-out-current-polarity,
maybe it's too specific.

-- 
Thanks,
 ~ Kurt

  reply	other threads:[~2026-06-21 23:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  0:33 [PATCH RFC 0/3] dt-bindings: iio: adc: Add reference, excitation and burn-out properties Kurt Borja
2026-06-19  0:33 ` [PATCH RFC 1/3] dt-bindings: iio: adc: Add reference-source property Kurt Borja
2026-06-19 14:14   ` Conor Dooley
2026-06-19 16:30     ` Kurt Borja
2026-06-19 14:24   ` David Lechner
2026-06-19 16:42     ` Kurt Borja
2026-06-19  0:33 ` [PATCH RFC 2/3] dt-bindings: iio: adc: Add excitation current sources properties Kurt Borja
2026-06-19 14:27   ` David Lechner
2026-06-19 16:44     ` Kurt Borja
2026-06-20 15:55       ` David Lechner
2026-06-19  0:33 ` [PATCH RFC 3/3] dt-bindings: iio: adc: Add burn-out current properties Kurt Borja
2026-06-19 14:28   ` David Lechner
2026-06-19 16:46     ` Kurt Borja
2026-06-20 15:57       ` David Lechner
2026-06-21 23:43         ` Kurt Borja [this message]
2026-06-19 14:23 ` [PATCH RFC 0/3] dt-bindings: iio: adc: Add reference, excitation and burn-out properties David Lechner
2026-06-19 16:35   ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJF4KBA0LX3K.Q3XDAO3J1HMP@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox