From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707ADC2BB1D for ; Fri, 17 Apr 2020 21:56:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49CFF2137B for ; Fri, 17 Apr 2020 21:56:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="ce83J6ce" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgDQV4R (ORCPT ); Fri, 17 Apr 2020 17:56:17 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:34438 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbgDQV4R (ORCPT ); Fri, 17 Apr 2020 17:56:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1587160574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aaxgJAnoG5ukjwAgRDDBUrEuKKAGyFMzh6K7D0/zApY=; b=ce83J6ceG6K8yfeaAwYEXJ4m//pzNDoVIIZQCvxo11x56yav1WOqJpSwJBkl8QcOiQOT4S QH0R/ICF8xfe9S8plTB2eQ6sDYa3p+mXZoCh1iHthVPjQoCVIpSUdmcT95iTczSSjzWASr 6jKFag5fRYobIXS3beGzhyX7F+Znhqk= Date: Fri, 17 Apr 2020 23:56:01 +0200 From: Paul Cercueil Subject: Re: [RESEND PATCH v5 3/5] IIO: Ingenic JZ47xx: Add touchscreen mode. To: Andy Shevchenko Cc: Artur Rojek , Dmitry Torokhov , Rob Herring , Mark Rutland , Jonathan Cameron , Heiko Stuebner , linux-input , devicetree , linux-iio , Linux Kernel Mailing List Message-Id: In-Reply-To: References: <20200417202859.35427-1-contact@artur-rojek.eu> <20200417202859.35427-3-contact@artur-rojek.eu> <3KAY8Q.NNI6X4F9QRIX1@crapouillou.net> <86BY8Q.C5XO8D57M7BI1@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Le sam. 18 avril 2020 =E0 0:52, Andy Shevchenko=20 a =E9crit : > On Sat, Apr 18, 2020 at 12:45 AM Paul Cercueil =20 > wrote: >> Le sam. 18 avril 2020 =E0 0:42, Andy Shevchenko >> a =E9crit : >> > On Sat, Apr 18, 2020 at 12:18 AM Paul Cercueil=20 >> >> > wrote: >> >> Le sam. 18 avril 2020 =E0 0:13, Andy Shevchenko >> >> a =E9crit : >> >> > On Sat, Apr 18, 2020 at 12:05 AM Paul Cercueil >> >> >> >> > wrote: >> >> >> Le ven. 17 avril 2020 =E0 23:59, Andy Shevchenko >> >> >> a =E9crit : >> >> >> > On Fri, Apr 17, 2020 at 11:21 PM Artur Rojek >> >> >> >> >> >> > wrote: >> >> > >> >> > ... >> >> > >> >> >> >> + irq =3D platform_get_irq(pdev, 0); >> >> >> > >> >> >> > Before it worked w/o IRQ, here is a regression you=20 >> introduced. >> >> >> >> >> >> Before it simply did not need the IRQ, which is provided by=20 >> the >> >> >> devicetree anyway. No regression here. >> >> > >> >> > Does it work without IRQ? Or it was a dead code till now? >> >> > For me it's clear regression. Otherwise something is really=20 >> wrong >> >> in a >> >> > process of development of this driver. >> >> >> >> Nothing wrong here. The IRQ was not used by the driver for the >> >> functionality it provided before. It is required now to support=20 >> the >> >> touchscreen channels. >> > >> > This is exactly what's wrong. >> > Previous DTS for my (hypothetical) case has no IRQ defined.=20 >> Everything >> > works, right? >> > Now, due to this change it breaks my setup. Don't you see the=20 >> problem? >>=20 >> The IRQ has been provided by every concerned DTS file since the >> introduction of this driver and the related bindings, even though it >> was not used by the driver. >=20 > Can you speak for all possible DTSs/DTBs in the wild? > Okay, in any case it will be problem of maintainers and yours if > somebody complains. I can, since I wrote all of them. -Paul > I'm not going to push this anyway -- your choice. >=20 > But I see a (potential) regression. >=20 >> >> >> >> + if (irq < 0) { >> >> >> > >> >> >> >> + dev_err(dev, "Failed to get irq: %d\n", >> >> irq); >> >> >> > >> >> >> > Redundant message. >> >> >> > >> >> >> >> + return irq; >> >> >> >> + } >=20 > -- > With Best Regards, > Andy Shevchenko