Re: [PATCH v9 3/5] Documentation: ABI: sysfs-bus-counter: add cascade_counts_enable and external_input_phase_clock_select

[William Breathitt Gray <william.gray@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 3411 bytes --]

On Wed, Dec 14, 2022 at 10:31:34AM +0000, Biju Das wrote:
> This commit adds cascade_counts_enable and external_input_phase_
> clock_select items to counter ABI file.
> (e.g. for Renesas MTU3 hardware used for phase counting).
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: William Breathitt Gray <william.gray@linaro.org>

> ---
> v8->v9:
>  * Added available blocks for external_input_phase_clock_select_available
>  * Removed the "This attribute" from the external_input_phase_clock_select
>    description, and capitalize the word "counter" from description.
>  * Removed the "This attribute" from the cascade_counts_enable description,
>    and capitalize "counts" and "counter"
>  * Moved these device-level configuration blocks to top of the file.
> v7->v8:
>  * Replaced cascade_enable->cascade_counts_enable
>  * Updated commit header and description
>  * Added external_input_phase_clock_select_available entry for driver-
>    specific enum attribute and created a new entry block for it.
>  * Add a line stating cascade_counts_enable is a boolean attribute.
>  * Added missing 'component_id' suffix.
> v6->v7:
>  * Replaced long_word_access_ctrl_mode->cascade_enable
>  * Updated Kernel version
> v5->v6:
>  * No change
> v5:
>  * New patch
> ---
>  Documentation/ABI/testing/sysfs-bus-counter | 32 +++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-counter b/Documentation/ABI/testing/sysfs-bus-counter
> index ff83320b4255..97c1bd7a5df2 100644
> --- a/Documentation/ABI/testing/sysfs-bus-counter
> +++ b/Documentation/ABI/testing/sysfs-bus-counter
> @@ -1,3 +1,33 @@
> +What:		/sys/bus/counter/devices/counterX/cascade_counts_enable
> +KernelVersion:	6.3
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Indicates the cascading of Counts on Counter X.
> +
> +		Valid attribute values are boolean.
> +
> +What:		/sys/bus/counter/devices/counterX/external_input_phase_clock_select
> +KernelVersion:	6.3
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Selects the external clock pin for phase counting mode of
> +		Counter X.
> +
> +		MTCLKA-MTCLKB:
> +			MTCLKA and MTCLKB pins are selected for the external
> +			phase clock.
> +
> +		MTCLKC-MTCLKD:
> +			MTCLKC and MTCLKD pins are selected for the external
> +			phase clock.
> +
> +What:		/sys/bus/counter/devices/counterX/external_input_phase_clock_select_available
> +KernelVersion:  6.3
> +Contact:        linux-iio@vger.kernel.org
> +Description:
> +                Discrete set of available values for the respective device
> +                configuration are listed in this file.
> +
>  What:		/sys/bus/counter/devices/counterX/countY/count
>  KernelVersion:	5.2
>  Contact:	linux-iio@vger.kernel.org
> @@ -215,6 +245,8 @@ Contact:	linux-iio@vger.kernel.org
>  Description:
>  		This attribute indicates the number of overflows of count Y.
>  
> +What:		/sys/bus/counter/devices/counterX/cascade_counts_enable_component_id
> +What:		/sys/bus/counter/devices/counterX/external_input_phase_clock_select_component_id
>  What:		/sys/bus/counter/devices/counterX/countY/capture_component_id
>  What:		/sys/bus/counter/devices/counterX/countY/ceiling_component_id
>  What:		/sys/bus/counter/devices/counterX/countY/floor_component_id
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]