From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: Use get_unaligned_beXX()
Date: Wed, 28 Dec 2022 12:08:53 +0200 [thread overview]
Message-ID: <Y6wVtZLpNzez4KlI@smile.fi.intel.com> (raw)
In-Reply-To: <20221223151750.6cb55f12@jic23-huawei>
On Fri, Dec 23, 2022 at 03:17:50PM +0000, Jonathan Cameron wrote:
> On Wed, 14 Dec 2022 14:02:01 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > This makes the driver code slightly easier to read.
> > While at it, use GENMASK() as well.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Hi Andy,
>
> Patch looks good, but it got me thinking. Why not just flip this driver
> over to using spi_write_then_read(). Would let us drop the DMA safety
> protections and simplify the code + use a __be16 as the read buffer
> and this would then be the slightly nicer aligned form.
>
> Worth doing whilst you are here?
OK, I will consider when I have time for this.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-28 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 12:02 [PATCH v1 1/2] iio: adc: ti-adc128s052: Use get_unaligned_beXX() Andy Shevchenko
2022-12-14 12:02 ` [PATCH v1 2/2] iio: adc: ti-adc128s052: Sort headers Andy Shevchenko
2022-12-23 15:17 ` [PATCH v1 1/2] iio: adc: ti-adc128s052: Use get_unaligned_beXX() Jonathan Cameron
2022-12-28 10:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wVtZLpNzez4KlI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox