From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EE3C4332F for ; Sat, 31 Dec 2022 18:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232239AbiLaSY3 (ORCPT ); Sat, 31 Dec 2022 13:24:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiLaSY2 (ORCPT ); Sat, 31 Dec 2022 13:24:28 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10D6DE9E; Sat, 31 Dec 2022 10:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672511068; x=1704047068; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=feTp/WmicBThxgI8tutjgB6YS3nkwvOhGW7b7yJzpIg=; b=P9BiFDRLUX/+2qbcR0jf/TUc3AWWla7evV5VIY1dBEPC5Dr405ee2d2S H4JU97yQh7S77bEg48vRrWOnD9AK1QdzHvlG+c1XYyCpjSHwzbjm7j0KY yD5UmxJlbTFxKdVs4zfLEXza7rFA85egtoV+QOy8oGQlIbiwmf/2aFozy ng1HuIXtzQjjpvyrkfKSUIRA7eQsjoPQVpie94c8T5DjHrb0GP2JXKawY H0CQhNl05xIl1hSFnZ3uZX1DpeO/4lMBwc1losHY/4rHGmii3sbOhCiZc KojtMGEcWINC0hFWoUBS8Nf3x1+ejlXZj94vKvQ2mKYRt3EjsWnMMMtvV w==; X-IronPort-AV: E=McAfee;i="6500,9779,10577"; a="319021498" X-IronPort-AV: E=Sophos;i="5.96,290,1665471600"; d="scan'208";a="319021498" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Dec 2022 10:24:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10577"; a="899505083" X-IronPort-AV: E=Sophos;i="5.96,290,1665471600"; d="scan'208";a="899505083" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 31 Dec 2022 10:24:26 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pBgWv-002PH3-0m; Sat, 31 Dec 2022 20:24:25 +0200 Date: Sat, 31 Dec 2022 20:24:24 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen Subject: Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() Message-ID: References: <20221214114944.83790-1-andriy.shevchenko@linux.intel.com> <20221223152242.2ee926eb@jic23-huawei> <20221223154450.458771b8@jic23-huawei> <20221231144558.44720f4d@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221231144558.44720f4d@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Dec 31, 2022 at 02:45:58PM +0000, Jonathan Cameron wrote: > On Wed, 28 Dec 2022 11:59:53 +0200 > Andy Shevchenko wrote: ... > I should have been more specific though I do mention rebasing to get the > patch above.. Doesn't build with it. > > Signature of spi_get_device_match_data is: > extern const void * > spi_get_device_match_data(const struct spi_device *sdev); > > and you are passing it a struct device * which rather implies you didn't > successfully build test this. Definitely. Thanks for spotting this, I'll investigate what happened on my side that it wasn't built. -- With Best Regards, Andy Shevchenko