From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Philippe De Muyter <Philippe.DeMuyter@macq.eu>
Cc: linux-iio@vger.kernel.org, Philippe De Muyter <phdm@macqel.be>
Subject: Re: [PATCH 1/2] iio: imu: st_lsm6dsx: fix naming of 'struct iio_info'.
Date: Mon, 16 Jan 2023 11:19:48 +0100 [thread overview]
Message-ID: <Y8UkxDgfeH7z3q7g@lore-desk> (raw)
In-Reply-To: <1673862685-29308-2-git-send-email-Philippe.DeMuyter@macq.eu>
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
> From: Philippe De Muyter <phdm@macqel.be>
>
> We need the name 'st_lsm6dsx_ext_info' for the actual 'iio_chan_spec_ext_info'.
> Rename the 'struct iio_info' to 'st_lsm6dsx_info' like in all other drivers.
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> index f2b64b4956a3..43304b198040 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> @@ -714,7 +714,7 @@ static const struct attribute_group st_lsm6dsx_ext_attribute_group = {
> .attrs = st_lsm6dsx_ext_attributes,
> };
>
> -static const struct iio_info st_lsm6dsx_ext_info = {
> +static const struct iio_info st_lsm6dsx_info = {
maybe st_lsm6dsx_shub_info is a better name, what do you think?
Moreover you can even rename:
s/st_lsm6dsx_ext_attributes/st_lsm6dsx_shub_attributes/
s/st_lsm6dsx_ext_attribute_group/st_lsm6dsx_shub_attribute_group/
Regards,
Lorenzo
> .attrs = &st_lsm6dsx_ext_attribute_group,
> .read_raw = st_lsm6dsx_shub_read_raw,
> .write_raw = st_lsm6dsx_shub_write_raw,
> @@ -737,7 +737,7 @@ st_lsm6dsx_shub_alloc_iiodev(struct st_lsm6dsx_hw *hw,
> return NULL;
>
> iio_dev->modes = INDIO_DIRECT_MODE;
> - iio_dev->info = &st_lsm6dsx_ext_info;
> + iio_dev->info = &st_lsm6dsx_info;
>
> sensor = iio_priv(iio_dev);
> sensor->id = id;
> --
> 2.31.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-16 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 9:51 [PATCH 0/2] iio: imu: st_lsm6dsx: add 'mount_matrix' sysfs entry to gyro channel Philippe De Muyter
2023-01-16 9:51 ` [PATCH 1/2] iio: imu: st_lsm6dsx: fix naming of 'struct iio_info' Philippe De Muyter
2023-01-16 10:19 ` Lorenzo Bianconi [this message]
2023-01-16 9:51 ` [PATCH 2/2] iio: imu: st_lsm6dsx: add 'mount_matrix' sysfs entry to gyro channel Philippe De Muyter
2023-01-16 10:16 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8UkxDgfeH7z3q7g@lore-desk \
--to=lorenzo@kernel.org \
--cc=Philippe.DeMuyter@macq.eu \
--cc=linux-iio@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).