From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93C1C3DA78 for ; Tue, 17 Jan 2023 15:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjAQP7C (ORCPT ); Tue, 17 Jan 2023 10:59:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjAQP7A (ORCPT ); Tue, 17 Jan 2023 10:59:00 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9732BF05 for ; Tue, 17 Jan 2023 07:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673971138; x=1705507138; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=/w+dJrVtCKUqjMAxdXAlcJK25bOJH9/p97S8eFefprg=; b=TYnjZmMwllA26nPTs6o68igdEWcLdNwK5f4TvdBaTRa28RzyKY71TJvk bH89aZn5n6QJIolCOqgCt3xXiO8+eiQSQbH+lnTgP0Rjtm6fELjH0RxE4 ZF8dpuKvCg+A2YgcKLU8C5QS/gBdDaDc6xT0MgWgIkButmrlp2Bw7F370 QG+ba3eouy0IOax8Nzh+Pcp7qfLDDxZ2qdEX1PTJA7k1eR274lG+4QSMI M5d0zwzMkvhUhMxveOanZaZXi79eUmwN15hwKGJJ//oio0rTb9DBPoqaz p7cjIIEApScK5hRX6GOzh4WJH453eynOFfbh4E6HV4pAaLj080hDKGYds w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="351975352" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="351975352" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 07:58:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="691635047" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="691635047" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 17 Jan 2023 07:58:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pHoMQ-00AeBO-2p; Tue, 17 Jan 2023 17:58:54 +0200 Date: Tue, 17 Jan 2023 17:58:54 +0200 From: Andy Shevchenko To: =?iso-8859-1?Q?M=E5rten?= Lindahl Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, kernel@axis.com Subject: Re: [PATCH v4 3/3] iio: light: vcnl4000: Add interrupt support for vcnl4040 Message-ID: References: <20230117152435.3510319-1-marten.lindahl@axis.com> <20230117152435.3510319-4-marten.lindahl@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230117152435.3510319-4-marten.lindahl@axis.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Jan 17, 2023 at 04:24:35PM +0100, Mårten Lindahl wrote: > Add support to configure proximity sensor interrupts and threshold > limits for vcnl4040. If an interrupt is detected an event will be > pushed to the event interface. ... > + return (dir == IIO_EV_DIR_RISING) ? > + FIELD_GET(VCNL4040_PS_IF_AWAY, ret) : > + FIELD_GET(VCNL4040_PS_IF_CLOSE, ret); Indentation issues? ... > + val = ret; > + > + if (dir == IIO_EV_DIR_RISING) > + val = state ? (val | VCNL4040_PS_IF_AWAY) : > + (val & ~VCNL4040_PS_IF_AWAY); > + else > + val = state ? (val | VCNL4040_PS_IF_CLOSE) : > + (val & ~VCNL4040_PS_IF_CLOSE); Wouldn't be better uXX val, mask; if (dir == IIO_EV_DIR_RISING) mask = VCNL4040_PS_IF_AWAY; else mask = VCNL4040_PS_IF_CLOSE; val = state ? (val | mask) : (val & ~mask); ? -- With Best Regards, Andy Shevchenko