From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mårten Lindahl" <martenli@axis.com>
Cc: "Mårten Lindahl" <marten.lindahl@axis.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-iio@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v2] iio: light: vcnl4000: Fix WARN_ON on uninitialized lock
Date: Tue, 31 Jan 2023 15:37:59 +0200 [thread overview]
Message-ID: <Y9kZt0Me9xPp3MaZ@smile.fi.intel.com> (raw)
In-Reply-To: <67f7888c-5d5b-4c63-42d3-cf2b15602478@axis.com>
On Tue, Jan 31, 2023 at 02:27:51PM +0100, Mårten Lindahl wrote:
> On 1/31/23 13:33, Andy Shevchenko wrote:
> > On Tue, Jan 31, 2023 at 11:29:51AM +0100, Mårten Lindahl wrote:
...
> > > - Trimmed backtrace in commit message
> > Not enough, please try harder. The ideal is to have ~3-5 lines of traceback.
>
> Hi Andy, Maybe I get it right soon ;). Could it perhaps be stripped like
> this?
Lockdep warning is important.
Assuming you left the warning still in place, almost there.
> Call trace:
> __mutex_lock
> mutex_lock_nested
> vcnl4200_set_power_state
> vcnl4200_init
> vcnl4000_probe
Can be cut out:
> i2c_device_probe
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-31 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 10:29 [PATCH v2] iio: light: vcnl4000: Fix WARN_ON on uninitialized lock Mårten Lindahl
2023-01-31 12:33 ` Andy Shevchenko
2023-01-31 12:37 ` Andy Shevchenko
2023-01-31 13:27 ` Mårten Lindahl
2023-01-31 13:37 ` Andy Shevchenko [this message]
2023-01-31 13:42 ` Mårten Lindahl
2023-01-31 12:46 ` Cai Huoqing
2023-01-31 13:33 ` Mårten Lindahl
2023-01-31 13:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9kZt0Me9xPp3MaZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marten.lindahl@axis.com \
--cc=martenli@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox