From: Mark Brown <broonie@kernel.org>
To: Okan Sahin <okan.sahin@analog.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
William Breathitt Gray <william.gray@linaro.org>,
ChiYuan Huang <cy_huang@richtek.com>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support
Date: Wed, 1 Feb 2023 14:30:12 +0000 [thread overview]
Message-ID: <Y9p3dIj+ix0A7SpR@sirena.org.uk> (raw)
In-Reply-To: <20230201103534.108136-3-okan.sahin@analog.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Wed, Feb 01, 2023 at 01:35:15PM +0300, Okan Sahin wrote:
> Regulator driver for both MAX77541 and MAX77540.
> The MAX77541 is a high-efficiency step-down converter
> with two 3A switching phases for single-cell Li+ battery
> and 5VDC systems.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
> + if (max77541->chip->id == MAX77540)
> + desc = max77540_regulators_desc;
> + else if (max77541->chip->id == MAX77541)
> + desc = max77541_regulators_desc;
> + else
> + return -EINVAL;
Write this as a switch statement for extensibility.
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-01 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:35 [PATCH v4 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-02-01 10:35 ` [PATCH v4 1/5] dt-bindings: regulator: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-02-01 14:46 ` Krzysztof Kozlowski
2023-02-01 10:35 ` [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-02-01 14:30 ` Mark Brown [this message]
2023-02-20 14:58 ` Sahin, Okan
2023-02-20 15:30 ` Andy Shevchenko
2023-02-02 13:30 ` Andy Shevchenko
2023-02-01 10:35 ` [PATCH v4 3/5] drivers: iio: adc: Add ADI MAX77541 ADC Support Okan Sahin
2023-02-01 14:44 ` Krzysztof Kozlowski
2023-02-02 13:37 ` Andy Shevchenko
2023-02-01 10:35 ` [PATCH v4 4/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540 Okan Sahin
2023-02-01 14:47 ` Krzysztof Kozlowski
2023-02-01 10:35 ` [PATCH v4 5/5] drivers: mfd: Add ADI MAX77541/MAX77540 PMIC Support Okan Sahin
2023-03-03 13:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9p3dIj+ix0A7SpR@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=caleb.connolly@linaro.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=okan.sahin@analog.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox