From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCC3C05027 for ; Thu, 2 Feb 2023 13:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbjBBNhn (ORCPT ); Thu, 2 Feb 2023 08:37:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbjBBNhm (ORCPT ); Thu, 2 Feb 2023 08:37:42 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7001F79CA6; Thu, 2 Feb 2023 05:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675345059; x=1706881059; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fNsHPoLmzNmFWV96A75FXJ5j6D1Zh89HMU5oA0Mj6NU=; b=G0AdybbEalquGCbHndHM+Da12x4PLQ2oW6PwzclxB446eC5FOk7r7jF4 8pjDjmHX87D052JiY7rOI+xUShRQol/BQwrHiQgkLZTiKLO3XVM2HsZI1 HzAAaow116m3IWhV4DVsEydvVc2G0x84NjpqXUJiJafTpaebtvdn8h4yx xLABDysiX7F0shBU53xGKH1HbKYXefWX8ToZ0w36Ez4mVNR3PaTunJFW0 HAm/wVYjW4YS9Saij/reUqPXIEgcj+VwnCByDkTaAyNiiH9EaLOxcMGsp z68bJm6UHQeWqt1Lg+PiFptNzQIwN9Gy/4HF/6T1Y45LY4fzM2+ngCsL8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="329733207" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="329733207" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 05:37:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="728859963" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="728859963" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 02 Feb 2023 05:37:34 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pNZmN-001Bwx-32; Thu, 02 Feb 2023 15:37:31 +0200 Date: Thu, 2 Feb 2023 15:37:31 +0200 From: Andy Shevchenko To: Okan Sahin Cc: Jonathan Cameron , Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Caleb Connolly , Marcus Folkesson , Ramona Bolboaca , ChiYuan Huang , Lad Prabhakar , William Breathitt Gray , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v4 3/5] drivers: iio: adc: Add ADI MAX77541 ADC Support Message-ID: References: <20230201103534.108136-1-okan.sahin@analog.com> <20230201103534.108136-4-okan.sahin@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201103534.108136-4-okan.sahin@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Feb 01, 2023 at 01:35:16PM +0300, Okan Sahin wrote: > The MAX77541 has an 8-bit Successive Approximation Register (SAR) ADC > with four multiplexers for supporting the telemetry feature. ... > +struct max77541_adc_iio { > + struct regmap *regmap; > +}; Is it really needed? See below. ... > +enum max77541_adc_channel { > + MAX77541_ADC_VSYS_V = 0, 0 is the default in C enums, why do you need this explicitly? If these are HW related, you need to assign them all to be crystal clear. > + MAX77541_ADC_VOUT1_V, > + MAX77541_ADC_VOUT2_V, > + MAX77541_ADC_TEMP, > +}; ... > + reg_val = FIELD_GET(MAX77541_BITS_MX_CFG1_RNG, reg_val); > + Redundant blank line. > + switch (reg_val) { > + case LOW_RANGE: > + *val = 6; > + *val2 = 250000; > + break; > + case MID_RANGE: > + *val = 12; > + *val2 = 500000; > + break; > + case HIGH_RANGE: > + *val = 25; > + return IIO_VAL_INT; > + default: > + return -EINVAL; > + } ... struct regmap **regmap; > + indio_dev = devm_iio_device_alloc(dev, sizeof(*info)); sizeof(*regmap) > + if (!indio_dev) > + return -ENOMEM; > + info = iio_priv(indio_dev); regmap = iio_priv(...); > + info->regmap = dev_get_regmap(dev->parent, NULL); *regmap = ...; It won't probably gain anything in the code generation or memory footprint, so up to you. But in general depending on API it might be a benefit. ... > +static const struct platform_device_id max77541_adc_platform_id[] = { > + { "max77541-adc", }, Inner comma is not needed. > + { /* sentinel */ } > +}; -- With Best Regards, Andy Shevchenko