From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Robin van der Gracht <robin@protonic.nl>,
linux-iio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter
Date: Tue, 23 Feb 2021 17:14:38 +0900 [thread overview]
Message-ID: <YDS5bp9vsG25nDeT@shinobu> (raw)
In-Reply-To: <20210223071630.lazyuvhr4xgqhafi@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
On Tue, Feb 23, 2021 at 08:16:30AM +0100, Oleksij Rempel wrote:
> Hi William,
>
> On Mon, Feb 22, 2021 at 10:48:56AM +0900, William Breathitt Gray wrote:
> > On Tue, Feb 16, 2021 at 09:13:54AM +0100, Oleksij Rempel wrote:
> > > changes v6:
> > > - rename it to interrupt-counter
> >
> > Hi Oleksij,
> >
> > Sorry to nitpick again, I think "irq-counter" as Jonathan suggested in
> > an earlier review would be a better name afterall. Would you be able to
> > rename this driver to use that name instead?
>
> I would prefer not to rename it. IRQ (Interrupt Request) is a signal
> outside of the system. Below some frequency rate, amount of counted
> ISR (interrupt service routine) calls or events would be equal to the actual
> IRQs. If frequency is too high, we will count ISR, but not IRQs. In
> any case, interrupt-counter is more or leas neutral, without triggering
> too many wrong assumptions.
>
> Regards,
> Oleksij
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
I suppose "interrupt-counter" should be fine in this context then, so
perhaps a rename isn't really necessary afterall.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-02-23 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 8:13 [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter Oleksij Rempel
2021-02-16 8:13 ` [PATCH v6 1/2] dt-bindings: counter: add event-counter binding Oleksij Rempel
2021-03-05 21:53 ` Rob Herring
2021-02-16 8:13 ` [PATCH v6 2/2] counter: add IRQ or GPIO based event counter Oleksij Rempel
2021-02-21 15:41 ` Jonathan Cameron
2021-02-22 1:48 ` [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter William Breathitt Gray
2021-02-23 7:16 ` Oleksij Rempel
2021-02-23 8:14 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDS5bp9vsG25nDeT@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox