From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Guoqing chi <chi962464zy@163.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, pmeerw@pmeerw.net,
chiguoqing@yulong.com
Subject: Re: [PATCH] iio: adc: ad7292: Modify the bool initialization assignment
Date: Sat, 20 Mar 2021 11:21:01 -0300 [thread overview]
Message-ID: <YFYEzYmdA7+St3WD@smtp.gmail.com> (raw)
In-Reply-To: <20210319062706.5135-1-chi962464zy@163.com>
Okay, looks good to me.
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
On 03/19, Guoqing chi wrote:
> From: Guoqing Chi <chiguoqing@yulong.com>
>
> A bool initializer is best assigned to false rather than 0.
>
> Signed-off-by: Guoqing Chi <chiguoqing@yulong.com>
> ---
> drivers/iio/adc/ad7292.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index 70e33dd1c9f7..3271a31afde1 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -260,7 +260,7 @@ static int ad7292_probe(struct spi_device *spi)
> struct ad7292_state *st;
> struct iio_dev *indio_dev;
> struct device_node *child;
> - bool diff_channels = 0;
> + bool diff_channels = false;
> int ret;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2021-03-20 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 6:27 [PATCH] iio: adc: ad7292: Modify the bool initialization assignment Guoqing chi
2021-03-20 14:21 ` Marcelo Schmitt [this message]
2021-03-20 15:07 ` Jonathan Cameron
2021-03-22 1:42 ` Guoqing Chi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFYEzYmdA7+St3WD@smtp.gmail.com \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=chi962464zy@163.com \
--cc=chiguoqing@yulong.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).