From: Dan Carpenter <dan.carpenter@oracle.com>
To: gwendal@chromium.org
Cc: linux-iio@vger.kernel.org
Subject: [bug report] iio: hrtimer: Allow sub Hz granularity
Date: Wed, 31 Mar 2021 17:50:37 +0300 [thread overview]
Message-ID: <YGSMPTIRAEQRyMWb@mwanda> (raw)
Hello Gwendal Grignou,
The patch dafcf4ed8392: "iio: hrtimer: Allow sub Hz granularity" from
Feb 25, 2021, leads to the following static checker warning:
drivers/iio/trigger/iio-trig-hrtimer.c:68 iio_hrtimer_store_sampling_frequency()
warn: assigned value is less than 'u32max'
drivers/iio/trigger/iio-trig-hrtimer.c
49 static
50 ssize_t iio_hrtimer_store_sampling_frequency(struct device *dev,
51 struct device_attribute *attr,
52 const char *buf, size_t len)
53 {
54 struct iio_trigger *trig = to_iio_trigger(dev);
55 struct iio_hrtimer_info *info = iio_trigger_get_drvdata(trig);
56 unsigned long long val;
57 u64 period;
58 int integer, fract, ret;
59
60 ret = iio_str_to_fixpoint(buf, 100, &integer, &fract);
61 if (ret)
62 return ret;
63 if (integer < 0 || fract < 0)
64 return -ERANGE;
65
66 val = fract + 1000 * integer; /* mHz */
^^^^^^^^^^^^^^^^^^^^^^
"fract" and "integer" are integers so the arithmatic will wrap instead
of going above UINT_MAX
67
68 if (!val || val > UINT_MAX)
^^^^^^^^^^^^^^
Unpossible!
69 return -EINVAL;
70
71 info->sampling_frequency[0] = integer; /* Hz */
72 info->sampling_frequency[1] = fract * 1000; /* uHz */
73 period = PSEC_PER_SEC;
74 do_div(period, val);
75 info->period = period; /* nS */
76
77 return len;
78 }
regards,
dan carpenter
next reply other threads:[~2021-03-31 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 14:50 Dan Carpenter [this message]
2021-04-05 16:27 ` [bug report] iio: hrtimer: Allow sub Hz granularity Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGSMPTIRAEQRyMWb@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox