From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/3] iio: imu: inv_mpu6050: Drop wrong use of ACPI_PTR()
Date: Sat, 5 Feb 2022 20:45:01 +0200 [thread overview]
Message-ID: <Yf7FrU3z7jgyv04f@smile.fi.intel.com> (raw)
In-Reply-To: <20220205164535.763feeea@jic23-huawei>
On Sat, Feb 05, 2022 at 04:45:35PM +0000, Jonathan Cameron wrote:
> On Thu, 3 Feb 2022 17:59:18 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > ACPI_PTR() is more harmful than helpful. For example, in this case
> > if CONFIG_ACPI=n, the ID table left unused which is not what we want.
> >
> > Instead of adding ifdeffery or attribute here and there, drop ACPI_PTR().
> >
> > Fixes: 3b3870646642 ("iio: imu: inv_mpu6050: Mark acpi match table as maybe unused")
> > Fixes: fd64df16f40e ("iio: imu: inv_mpu6050: Add SPI support for MPU6000")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Hi Andy,
>
> Whilst I fully support tidying this up, what is 'fixing' as such?
> Will get rid of an unused warning for the spi case but that sort
> of things doesn't always get fixes tags.
True, however I can find a handful examples when this kind of patches were backported.
> They tend to result
> in backports and I wouldn't think it was worth backporting this
> unless I'm missing something...
It's not critical, so can you drop the tags when applying, if you think that's
okay?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-02-05 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 15:59 [PATCH v1 1/3] iio: imu: inv_mpu6050: Drop wrong use of ACPI_PTR() Andy Shevchenko
2022-02-03 15:59 ` [PATCH v1 2/3] iio: imu: inv_mpu6050: Check ACPI companion directly Andy Shevchenko
2022-02-03 15:59 ` [PATCH v1 3/3] iio: imu: inv_mpu6050: Make use of device properties Andy Shevchenko
2022-02-05 16:45 ` [PATCH v1 1/3] iio: imu: inv_mpu6050: Drop wrong use of ACPI_PTR() Jonathan Cameron
2022-02-05 18:45 ` Andy Shevchenko [this message]
2022-02-06 15:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf7FrU3z7jgyv04f@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox