From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1AAC433EF for ; Thu, 10 Feb 2022 13:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242288AbiBJNzj (ORCPT ); Thu, 10 Feb 2022 08:55:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242477AbiBJNzi (ORCPT ); Thu, 10 Feb 2022 08:55:38 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9405FD73; Thu, 10 Feb 2022 05:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644501337; x=1676037337; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ay0A3kx32MJfbLcM+1m+RIYTgc6yue+5l1DCkhN+RZI=; b=OkBvhrv96X0VwdktPXcb9GyfjCVRQfdbThoMmqyRPDKtRy8/5vd3mUPi esiHAqL8qF95Z6QP4jLkQSEmmPDLHQ58jOgrmn/kfAo0EJ1ucR4Snm0aV m/QKjbNDHWk07nJCiHo6Xj4IgzkUEZKvUB0VW90xzfz7NN4to4yhcPoht JGjOTNX7pJjBhAfllRpLAC2YvggisMSaFDj+JdfpPcwYyHT47+zVaTCv3 ukgiB6kWdZnaO0axU/CrqN+ra3M63nrpHNubXFrf1pHovXaMRATWybG+Q jtqefbAMO48rL990FEGmWs3032NiNYBa5KZoSbGhALDvs2eenZFLRsJX1 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="230138803" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="230138803" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 05:55:37 -0800 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="485691556" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 05:55:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nI9u9-0030X4-OH; Thu, 10 Feb 2022 15:54:37 +0200 Date: Thu, 10 Feb 2022 15:54:37 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: Joe Perches , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?iso-8859-1?Q?S=E1?= , Lars-Peter Clausen Subject: Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Message-ID: References: <20220207104830.83882-1-andriy.shevchenko@linux.intel.com> <20220207204421.7f905aa5@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207204421.7f905aa5@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Feb 07, 2022 at 08:44:21PM +0000, Jonathan Cameron wrote: > On Mon, 7 Feb 2022 19:21:25 +0200 > Andy Shevchenko wrote: > > > On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote: > > > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote: > > > > In a couple of messages the constants, which have their definitions, > > > > are hard coded into the message text. Unhardcode them. > > > > > > Found by inspection or tool? > > > > Does it matter? No, a side effect of the following patch. > > > > ... > > > > > > + dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size, > > > > + LTC2983_CUSTOM_STEINHART_SIZE); > > > > > > probably better using "%u" and not "%d" > > > > > > and better with a \n termination too. > > > > I think it would be a separate change if we wish so. Let Jonathan to tell what > > to do here. > > > Either way is fine by me. I tend to be a little flexible of trivial fixes > in patches that are as simple as this one. v3 has been just sent. -- With Best Regards, Andy Shevchenko