From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-iio@vger.kernel.org, Daniel Baluta <daniel.baluta@nxp.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 4/6] iio: adc: ti-ads1015: Deduplicate channel macros
Date: Thu, 10 Mar 2022 16:25:43 +0200 [thread overview]
Message-ID: <YioKZ6EZvYHOOFMe@smile.fi.intel.com> (raw)
In-Reply-To: <20220310003402.490478-4-marex@denx.de>
On Thu, Mar 10, 2022 at 01:34:00AM +0100, Marek Vasut wrote:
> These macros differ only in the number of valid bits of each ADC sample
> and the shift of those bits, i.e. ADS1015 is 12bit ADC shifted by 4 left,
> ADS1115 is 16bit ADC shifted by 0. No functional change.
> Signed-off-by: Marek Vasut <marex@denx.de>
...
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
You may consider using --cc parameter in `git send-email` to avoid this noise
in the commit messages.
...
> - .realbits = 12, \
> + .realbits = (_realbits), \
> .storagebits = 16, \
This seems inconsistent a bit. What if the next chip wants to have more than
16 bits in realbits?
...
> - .realbits = 16, \
> + .realbits = (_realbits), \
> .storagebits = 16, \
Ditto.
I see two options:
1) add static assert to make sure realbits <= storagebits;
2) make it also configurable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-10 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 0:33 [PATCH 1/6] dt-bindings: iio: adc: ti,ads1015: Add missing ADS1115 compatible string Marek Vasut
2022-03-10 0:33 ` [PATCH 2/6] dt-bindings: iio: adc: ti,ads1015: Add TLA2024 " Marek Vasut
2022-03-10 12:52 ` Krzysztof Kozlowski
2022-03-10 0:33 ` [PATCH 3/6] iio: adc: ti-ads1015: Switch to static const writeable ranges table Marek Vasut
2022-03-10 0:34 ` [PATCH 4/6] iio: adc: ti-ads1015: Deduplicate channel macros Marek Vasut
2022-03-10 14:25 ` Andy Shevchenko [this message]
2022-03-10 23:29 ` Marek Vasut
2022-03-11 11:29 ` Andy Shevchenko
2022-03-11 11:33 ` Marek Vasut
2022-03-11 17:03 ` Andy Shevchenko
2022-03-11 18:51 ` Marek Vasut
2022-03-20 13:22 ` Jonathan Cameron
2022-03-10 0:34 ` [PATCH 5/6] iio: adc: ti-ads1015: Make channel event_spec optional Marek Vasut
2022-03-10 0:34 ` [PATCH 6/6] iio: adc: ti-ads1015: Add TLA2024 support Marek Vasut
2022-03-10 12:51 ` [PATCH 1/6] dt-bindings: iio: adc: ti,ads1015: Add missing ADS1115 compatible string Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YioKZ6EZvYHOOFMe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=daniel.baluta@nxp.com \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox