From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 340C8C433F5 for ; Mon, 21 Mar 2022 16:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348974AbiCUQVV (ORCPT ); Mon, 21 Mar 2022 12:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344109AbiCUQVU (ORCPT ); Mon, 21 Mar 2022 12:21:20 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89ADFA8EDE for ; Mon, 21 Mar 2022 09:19:55 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6200,9189,10293"; a="238195877" X-IronPort-AV: E=Sophos;i="5.90,199,1643702400"; d="scan'208";a="238195877" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 09:19:40 -0700 X-IronPort-AV: E=Sophos;i="5.90,199,1643702400"; d="scan'208";a="500224533" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 09:19:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nWKkH-0040rE-Go; Mon, 21 Mar 2022 18:19:01 +0200 Date: Mon, 21 Mar 2022 18:19:01 +0200 From: Andy Shevchenko To: Marek Vasut Cc: linux-iio , Daniel Baluta , Jonathan Cameron Subject: Re: [PATCH v3 10/10] iio: adc: ti-ads1015: Switch to read_avail Message-ID: References: <20220320181428.168109-1-marex@denx.de> <20220320181428.168109-10-marex@denx.de> <8c5772a7-6939-ac33-7b10-acded2b7b9ac@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c5772a7-6939-ac33-7b10-acded2b7b9ac@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Mar 21, 2022 at 03:44:24PM +0100, Marek Vasut wrote: > On 3/21/22 10:27, Andy Shevchenko wrote: > > On Sun, Mar 20, 2022 at 8:14 PM Marek Vasut wrote: ... > > > +static const int ads1015_fullscale_range[] = { > > > 6144, 4096, 2048, 1024, 512, 256, 256, 256 > > > > Keep a comma at the end. > > Also applies to the rest of the modified data structures below. > > Why ? We don't expect these arrays to grow new values, if there is ever some > new ADC, it will likely have its own array. Just for the sake of a common style. But it's not critical, so I leave it to the maintainers. -- With Best Regards, Andy Shevchenko