From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [RESEND PATCH 4/5] iio: imu: lsm6dsx: Use new pm_sleep_ptr() and EXPORT_SIMPLE_DEV_PM_OPS()
Date: Mon, 6 Jun 2022 10:37:00 +0200 [thread overview]
Message-ID: <Yp28rLIxHgcihx70@lore-desk> (raw)
In-Reply-To: <20220604161223.461847-5-jic23@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 4016 bytes --]
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> These new functions move the burden of removing unused code when
> CONFIG_PM_SLEEP is not defined onto the compiler rather than requiring
> the use of CONFIG_PM guards and similar.
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Link: https://lore.kernel.org/r/20220220181522.541718-8-jic23@kernel.org
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 10 ++++------
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c | 2 +-
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 2 +-
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c | 2 +-
> 4 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 910397716833..9e4aa5c1c8d6 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2291,7 +2291,7 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
> }
> EXPORT_SYMBOL(st_lsm6dsx_probe);
>
> -static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
> +static int st_lsm6dsx_suspend(struct device *dev)
> {
> struct st_lsm6dsx_hw *hw = dev_get_drvdata(dev);
> struct st_lsm6dsx_sensor *sensor;
> @@ -2330,7 +2330,7 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
> return err;
> }
>
> -static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
> +static int st_lsm6dsx_resume(struct device *dev)
> {
> struct st_lsm6dsx_hw *hw = dev_get_drvdata(dev);
> struct st_lsm6dsx_sensor *sensor;
> @@ -2366,10 +2366,8 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
> return err;
> }
>
> -const struct dev_pm_ops st_lsm6dsx_pm_ops = {
> - SET_SYSTEM_SLEEP_PM_OPS(st_lsm6dsx_suspend, st_lsm6dsx_resume)
> -};
> -EXPORT_SYMBOL(st_lsm6dsx_pm_ops);
> +EXPORT_SIMPLE_DEV_PM_OPS(st_lsm6dsx_pm_ops, st_lsm6dsx_suspend,
> + st_lsm6dsx_resume);
>
> MODULE_AUTHOR("Lorenzo Bianconi <lorenzo.bianconi@st.com>");
> MODULE_AUTHOR("Denis Ciocca <denis.ciocca@st.com>");
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> index 715fbdc8190e..5bd565b93a8c 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> @@ -134,7 +134,7 @@ MODULE_DEVICE_TABLE(i2c, st_lsm6dsx_i2c_id_table);
> static struct i2c_driver st_lsm6dsx_driver = {
> .driver = {
> .name = "st_lsm6dsx_i2c",
> - .pm = &st_lsm6dsx_pm_ops,
> + .pm = pm_sleep_ptr(&st_lsm6dsx_pm_ops),
> .of_match_table = st_lsm6dsx_i2c_of_match,
> },
> .probe = st_lsm6dsx_i2c_probe,
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> index 35556cd04284..4df186499802 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> @@ -44,7 +44,7 @@ static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
> static struct i3c_driver st_lsm6dsx_driver = {
> .driver = {
> .name = "st_lsm6dsx_i3c",
> - .pm = &st_lsm6dsx_pm_ops,
> + .pm = pm_sleep_ptr(&st_lsm6dsx_pm_ops),
> },
> .probe = st_lsm6dsx_i3c_probe,
> .id_table = st_lsm6dsx_i3c_ids,
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> index f5767cf76c1d..3a206fd4d92c 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> @@ -134,7 +134,7 @@ MODULE_DEVICE_TABLE(spi, st_lsm6dsx_spi_id_table);
> static struct spi_driver st_lsm6dsx_driver = {
> .driver = {
> .name = "st_lsm6dsx_spi",
> - .pm = &st_lsm6dsx_pm_ops,
> + .pm = pm_sleep_ptr(&st_lsm6dsx_pm_ops),
> .of_match_table = st_lsm6dsx_spi_of_match,
> },
> .probe = st_lsm6dsx_spi_probe,
> --
> 2.36.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-06-06 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-04 16:12 [RESEND PATCH 0/5] IIO: Where dev_pm_ops rework and namespaces meet (4-8) Jonathan Cameron
2022-06-04 16:12 ` [RESEND PATCH 1/5] iio:accel:kxsd9: Switch from CONFIG_PM guards to pm_ptr() etc Jonathan Cameron
2022-06-04 16:12 ` [RESEND PATCH 2/5] iio: humidity: hts221: Use EXPORT_SIMPLE_DEV_PM_OPS() to allow compiler to remove dead code Jonathan Cameron
2022-06-06 8:38 ` Lorenzo Bianconi
2022-06-04 16:12 ` [RESEND PATCH 3/5] iio: humidity: hts221: Move symbol exports into IIO_HTS221 namespace Jonathan Cameron
2022-06-06 8:37 ` Lorenzo Bianconi
2022-06-04 16:12 ` [RESEND PATCH 4/5] iio: imu: lsm6dsx: Use new pm_sleep_ptr() and EXPORT_SIMPLE_DEV_PM_OPS() Jonathan Cameron
2022-06-06 8:37 ` Lorenzo Bianconi [this message]
2022-06-04 16:12 ` [RESEND PATCH 5/5] iio: imu: lsm6dsx: Move exported symbols to the IIO_LSM6DSX namespace Jonathan Cameron
2022-06-06 8:35 ` Lorenzo Bianconi
2022-06-11 18:26 ` [RESEND PATCH 0/5] IIO: Where dev_pm_ops rework and namespaces meet (4-8) Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp28rLIxHgcihx70@lore-desk \
--to=lorenzo@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox