Linux IIO development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] counter: 104-quad-8: Fix skipped IRQ lines during events configuration
Date: Thu, 22 Sep 2022 13:27:52 +0200	[thread overview]
Message-ID: <YyxGuNPUP/febc9E@kroah.com> (raw)
In-Reply-To: <179eed11eaf225dbd908993b510df0c8f67b1230.1663844776.git.william.gray@linaro.org>

On Thu, Sep 22, 2022 at 07:20:56AM -0400, William Breathitt Gray wrote:
> IRQ trigger configuration is skipped if it has already been set before;
> however, the IRQ line still needs to be OR'd to irq_enabled because
> irq_enabled is reset for every events_configure call. This patch moves
> the irq_enabled OR operation update to before the irq_trigger check so
> that IRQ line enablement is not skipped.
> 
> Fixes: c95cc0d95702 ("counter: 104-quad-8: Fix persistent enabled events bug")
> Link: https://lore.kernel.org/r/20220815122301.2750-1-william.gray@linaro.org/
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>

This should have also cc: stable.  I'll add that when I apply it,
thanks.

greg k-h

  reply	other threads:[~2022-09-22 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 11:20 [PATCH 0/2] First set of Counter fixes for 6.0 William Breathitt Gray
2022-09-22 11:20 ` [PATCH 1/2] counter: 104-quad-8: Fix skipped IRQ lines during events configuration William Breathitt Gray
2022-09-22 11:27   ` Greg KH [this message]
2022-09-22 11:20 ` [PATCH 2/2] counter: Realign counter_comp comment block to 80 characters William Breathitt Gray
2022-09-22 11:28   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyxGuNPUP/febc9E@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=william.gray@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox