From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Lee Jones <lee@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Tony Lindgren <tony@atomide.com>,
linux-iio@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include
Date: Tue, 27 Sep 2022 15:24:49 +0300 [thread overview]
Message-ID: <YzLrkSwngUwlyTGZ@smile.fi.intel.com> (raw)
In-Reply-To: <20220927052217.2784593-1-dmitry.torokhov@gmail.com>
On Mon, Sep 26, 2022 at 10:22:13PM -0700, Dmitry Torokhov wrote:
> The driver is using of_match_ptr() and therefore needs to include
> of.h header.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/misc/twl4030-pwrbutton.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index b307cca17022..e3ee0638ffba 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -26,6 +26,7 @@
> #include <linux/errno.h>
> #include <linux/input.h>
> #include <linux/interrupt.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/twl.h>
>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-27 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 5:22 [PATCH 1/4] Input: twl4030-pwrbutton - add missing of.h include Dmitry Torokhov
2022-09-27 5:22 ` [PATCH 2/4] watchdog: twl4030_wdt: " Dmitry Torokhov
2022-09-27 10:55 ` Guenter Roeck
2022-09-27 12:23 ` Andy Shevchenko
2022-09-27 5:22 ` [PATCH 3/4] mfd: twl4030-irq: add missing device.h include Dmitry Torokhov
2022-09-27 12:25 ` Andy Shevchenko
2022-09-27 5:22 ` [PATCH 4/4] iio: adc: twl4030-madc: add missing of.h include Dmitry Torokhov
2022-09-27 12:24 ` Andy Shevchenko
2022-09-27 15:36 ` Dmitry Torokhov
2022-09-27 15:54 ` Andy Shevchenko
2022-09-27 12:24 ` Andy Shevchenko [this message]
2022-09-28 6:48 ` [PATCH 1/4] Input: twl4030-pwrbutton - " Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLrkSwngUwlyTGZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tony@atomide.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox