From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Eason Yang <j2anfernee@gmail.com>
Cc: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, jic23@kernel.org, lars@metafoo.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
nuno.sa@analog.com, dlechner@baylibre.com,
javier.carrasco.cruz@gmail.com, marcelo.schmitt@analog.com,
olivier.moysan@foss.st.com, mitrutzceclan@gmail.com,
tgamblin@baylibre.com, matteomartelli3@gmail.com,
alisadariana@gmail.com, gstols@baylibre.com,
thomas.bonnefille@bootlin.com, ramona.nechita@analog.com,
mike.looijmans@topic.nl, chanh@os.amperecomputing.com,
KWLIU@nuvoton.com, yhyang2@nuvoton.com, openbmc@lists.ozlabs.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add Nuvoton NCT720x ADC driver
Date: Tue, 3 Dec 2024 15:50:09 +0200 [thread overview]
Message-ID: <Z08MkR40fjfW3MXZ@smile.fi.intel.com> (raw)
In-Reply-To: <20241203091540.3695650-3-j2anfernee@gmail.com>
On Tue, Dec 03, 2024 at 05:15:40PM +0800, Eason Yang wrote:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
Please, get rid of explicit castings where the are not needed or implied, like
u16 foo;
...
foo = (u16)bar;
you have a lot of this in the code.
Second, why do you need two regmaps? How debugfs is supposed to work on the
registers that are 16-bit if you access them via 8-bit regmap and vice versa?
Can't you simply use bulk reads/writes when it makes sense and drop 16-bit
regmap completely?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-03 13:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 9:15 [PATCH v2 0/2] iio: adc: add Nuvoton NCT720x ADC driver Eason Yang
2024-12-03 9:15 ` [PATCH v2 1/2] dt-bindings: iio: adc: Add binding for Nuvoton NCT720x ADCs Eason Yang
2024-12-03 9:25 ` Krzysztof Kozlowski
2024-12-04 3:10 ` Yu-Hsian Yang
2024-12-04 7:12 ` Krzysztof Kozlowski
2024-12-04 8:47 ` Yu-Hsian Yang
2024-12-03 9:15 ` [PATCH v2 2/2] iio: adc: add Nuvoton NCT720x ADC driver Eason Yang
2024-12-03 13:50 ` Andy Shevchenko [this message]
2024-12-04 3:20 ` Yu-Hsian Yang
2024-12-04 4:27 ` Andy Shevchenko
2024-12-04 9:05 ` Yu-Hsian Yang
2024-12-08 17:16 ` Jonathan Cameron
2024-12-05 18:22 ` David Lechner
2024-12-05 19:01 ` David Lechner
2024-12-10 5:27 ` Yu-Hsian Yang
2024-12-10 5:20 ` Yu-Hsian Yang
2024-12-08 17:22 ` Jonathan Cameron
2024-12-10 5:38 ` Yu-Hsian Yang
2024-12-10 5:47 ` Yu-Hsian Yang
2024-12-11 18:28 ` Jonathan Cameron
2024-12-11 18:26 ` Jonathan Cameron
2024-12-08 17:47 ` Christophe JAILLET
2024-12-10 5:59 ` Yu-Hsian Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z08MkR40fjfW3MXZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=KWLIU@nuvoton.com \
--cc=alisadariana@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gstols@baylibre.com \
--cc=j2anfernee@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=matteomartelli3@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tgamblin@baylibre.com \
--cc=thomas.bonnefille@bootlin.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yhyang2@nuvoton.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox