From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
gregkh@linuxfoundation.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h
Date: Mon, 9 Dec 2024 02:45:46 +0200 [thread overview]
Message-ID: <Z1Y9uqGyq-yuxoEe@smile.fi.intel.com> (raw)
In-Reply-To: <20241208171001.4994e749@jic23-huawei>
On Sun, Dec 08, 2024 at 05:10:01PM +0000, Jonathan Cameron wrote:
> On Tue, 3 Dec 2024 21:48:51 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > device.h is a huge header which is hard to follow and easy to miss
> > something. Improve that by splitting devres APIs to device/devres.h.
> >
> > In particular this helps to speedup the build of the code that includes
> > device.h solely for a devres APIs.
...
> > -#include <linux/overflow.h>
> > +
> Unrelated change.
Which one? Blank line?
...
> > -#include <linux/cleanup.h>
> This header movement is unrelated.
No problem to let it stay at the same place.
> I agree both are good but probably want to be a separate patch.
>
> Otherwise this seems sensible to me, but your cc list seems a little short!
>
> Greg and Rafael seems a good starting point so I've added them.
Thanks! I need to check why they were not included into the original
submission. Perhpas I need to amend MAINTAINERS,
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-09 0:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 19:48 [PATCH v1 0/2] driver core: move devres APIs to a separate header Andy Shevchenko
2024-12-03 19:48 ` [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h Andy Shevchenko
2024-12-08 17:10 ` Jonathan Cameron
2024-12-09 0:45 ` Andy Shevchenko [this message]
2024-12-11 18:29 ` Jonathan Cameron
2024-12-12 14:35 ` Andy Shevchenko
2024-12-03 19:48 ` [PATCH v1 2/2] iio: imu: st_lsm9ds0: Replace device.h with what is needed Andy Shevchenko
2025-01-21 6:01 ` Raag Jadav
2025-01-21 13:25 ` Andy Shevchenko
2024-12-12 14:34 ` [PATCH v1 0/2] driver core: move devres APIs to a separate header Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1Y9uqGyq-yuxoEe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox