From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB5814A8B for ; Sun, 12 Jan 2025 15:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736695176; cv=none; b=fw3dwrk2D2Gh8x6ebdkz3sU5peUvOngV/gVu05Hb382jn6662UEdtqowHvYiASTvH41cjrjNo1ThPXP6KEaL63Cg3iDo+6UWFckvoDv0zvSjK1sh/XlbhuvBBQ6hd+7YGUHLhiVC87KmErlIhZKiUuyzZqPPWPmK/LM5erF/Hss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736695176; c=relaxed/simple; bh=Y859hFfsyLG+z8zpMAplC1EJG1kcGjOa5EFaIJocxyo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UpnHs+8N8l2/xixqx/2BuxsL8K037ynSMXhRjsxlFlKkeAZG1dDItaYIXa3lDWqdaC1vEzuEANnSq7CkA2EgEl9aqEJPCdEcj5FLk6G1W0KeVkt5t4snbrVlsIZlJWcf/U0IGRT2OHaY1CesGZu2R/Gs732/JaRquROtMhy3bv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-143.elisa-laajakaista.fi [88.113.25.143]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 76eb2478-d0f8-11ef-9cd8-005056bd6ce9; Sun, 12 Jan 2025 17:18:24 +0200 (EET) From: Andy Shevchenko Date: Sun, 12 Jan 2025 17:18:23 +0200 To: Javier Carrasco Cc: Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH v2 3/4] iio: light: veml3235: extend regmap to add cache Message-ID: References: <20241224-veml3235_scale-v2-0-2e1286846c77@gmail.com> <20241224-veml3235_scale-v2-3-2e1286846c77@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241224-veml3235_scale-v2-3-2e1286846c77@gmail.com> Tue, Dec 24, 2024 at 11:59:02AM +0100, Javier Carrasco kirjoitti: > The configuration and ID registers are not volatile and are not affected > by read operations (i.e. not precious), making them suitable to be > cached in order to reduce the number of accesses to the device. ... > static const struct regmap_config veml3235_regmap_config = { > .name = "veml3235_regmap", > .reg_bits = 8, > .val_bits = 16, > .max_register = VEML3235_REG_ID, > .val_format_endian = REGMAP_ENDIAN_LITTLE, > + .rd_table = &veml3235_readable_table, > + .wr_table = &veml3235_writable_table, > + .volatile_table = &veml3235_volatile_table, > + .cache_type = REGCACHE_RBTREE, Any specific reason why this is NOT a maple tree? > }; -- With Best Regards, Andy Shevchenko