From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
eraretuya@gmail.com
Subject: Re: [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value for SPI
Date: Sun, 12 Jan 2025 17:54:22 +0200 [thread overview]
Message-ID: <Z4PlrkU6Ml9N4tx1@surfacebook.localdomain> (raw)
In-Reply-To: <20241228232949.72487-3-l.rubusch@gmail.com>
Sat, Dec 28, 2024 at 11:29:47PM +0000, Lothar Rubusch kirjoitti:
> Add the possibility to delay FIFO access when SPI is used. According to
> the datasheet this is needed for the adxl345. When initialization
> happens over SPI the need for delay is to be signalized, and the delay
> will be used.
...
> int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> + bool fifo_delay_default,
> int (*setup)(struct device*, struct regmap*));
Missing spaces, but it seems the original issue.
...
> int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> + bool fifo_delay_default,
> int (*setup)(struct device*, struct regmap*))
Ditto.
...
> #define ADXL345_MAX_SPI_FREQ_HZ 5000000
> +#define ADXL345_MAX_FREQ_NO_FIFO_DELAY 1500000
In which units? Usually we add a unit suffix, e.g., _US (for microseconds).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-12 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 23:29 [PATCH v9 0/4] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events Lothar Rubusch
2024-12-28 23:29 ` [PATCH v9 1/4] iio: accel: adxl345: introduce interrupt handling Lothar Rubusch
2024-12-28 23:29 ` [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value for SPI Lothar Rubusch
2025-01-12 15:54 ` Andy Shevchenko [this message]
2024-12-28 23:29 ` [PATCH v9 3/4] iio: accel: adxl345: add FIFO with watermark events Lothar Rubusch
2025-01-04 13:08 ` Jonathan Cameron
2025-01-12 16:05 ` Andy Shevchenko
2024-12-28 23:29 ` [PATCH v9 4/4] iio: accel: adxl345: complete the list of defines Lothar Rubusch
2025-01-04 13:09 ` [PATCH v9 0/4] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events Jonathan Cameron
2025-01-05 22:22 ` Lothar Rubusch
2025-01-12 16:06 ` Andy Shevchenko
2025-01-12 16:38 ` Jonathan Cameron
2025-01-12 19:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4PlrkU6Ml9N4tx1@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox