From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Trevor Gamblin" <tgamblin@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7625: Add ending newlines to error messages
Date: Sun, 12 Jan 2025 18:37:46 +0200 [thread overview]
Message-ID: <Z4Pv2jpBZRrbl0oy@surfacebook.localdomain> (raw)
In-Reply-To: <20250104131132.4c20b330@jic23-huawei>
Sat, Jan 04, 2025 at 01:11:32PM +0000, Jonathan Cameron kirjoitti:
> On Mon, 30 Dec 2024 10:15:21 -0500
> Trevor Gamblin <tgamblin@baylibre.com> wrote:
> > On 2024-12-30 10:10, Uwe Kleine-König wrote:
> > > Error messages passed to dev_err_probe() are supposed to end in "\n".
> > > Fix accordingly.
> > >
> > > Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > Tested-by: Trevor Gamblin <tgamblin@baylibre.com>
Actually Q to everybody: do you know that "supposed" in this commit message is
just a good style as dev_*() are all automatically add newline AFAICS?
P.S. Recently discussed this topic with Linus W. and if I'm not mistaken one
should never see an issue with those messages in the dmesg. OTOH, all other
means that try to save or do anything with messages w/o \n should be aware.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-01-12 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 15:10 [PATCH] iio: adc: ad7625: Add ending newlines to error messages Uwe Kleine-König
2024-12-30 15:15 ` Trevor Gamblin
2025-01-04 13:11 ` Jonathan Cameron
2025-01-12 16:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Pv2jpBZRrbl0oy@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tgamblin@baylibre.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox