From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v4] iio: cros_ec: Trace EC sensors command
Date: Wed, 22 Jan 2025 06:14:19 +0000 [thread overview]
Message-ID: <Z5CMu4yIgbPgJknf@google.com> (raw)
In-Reply-To: <20250121232007.1020666-1-gwendal@chromium.org>
On Tue, Jan 21, 2025 at 03:20:07PM -0800, Gwendal Grignou wrote:
> For debugging, add tracing for EC_CMD_MOTION_SENSE_CMD command:
> - decode the name of the subcommand
> - provide internal information for the most common sub-commands:
> setting range, frequency, EC probing frequency, ...
> - display return status.
>
> When enabled, the tracing output is similar to:
> /sys/kernel/debug/tracing # echo 1 > events/cros_ec/enable ; echo 1 > tracing_on ; cat trace_pipe | grep MOTIONSENSE_CMD_SENSOR_ODR
> SensorDeviceImp-814 [003] ..... 686.176782: cros_ec_motion_host_cmd: MOTIONSENSE_CMD_SENSOR_ODR, id: 1, data: 200000, result: 4, return: 12500
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Except I can't verify the build error seen in v3, the patch looks good to me,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> ---
> Changes from v2 (https://patchwork.kernel.org/patch/13944028/):
> - Fix include error, based on commit a98c75fcd0e ("drm/tegra: trace: Fix path to include")
Typo, v3.
next prev parent reply other threads:[~2025-01-22 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 23:20 [PATCH v4] iio: cros_ec: Trace EC sensors command Gwendal Grignou
2025-01-22 6:14 ` Tzung-Bi Shih [this message]
2025-01-25 12:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5CMu4yIgbPgJknf@google.com \
--to=tzungbi@kernel.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox