linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH v6 02/10] property: Add functions to iterate named child
Date: Mon, 10 Mar 2025 16:51:26 +0200	[thread overview]
Message-ID: <Z878bsd7i-wAuCZ6@smile.fi.intel.com> (raw)
In-Reply-To: <ff924f640feeb87819d40557f12a04e607894682.1741610847.git.mazziesaccount@gmail.com>

On Mon, Mar 10, 2025 at 02:55:53PM +0200, Matti Vaittinen wrote:
> There are a few use-cases where child nodes with a specific name need to
> be parsed. Code like:
> 
> fwnode_for_each_child_node()
> 	if (fwnode_name_eq())
> 		...
> 
> can be found from a various drivers/subsystems. Adding a macro for this
> can simplify things a bit.
> 
> In a few cases the data from the found nodes is later added to an array,
> which is allocated based on the number of found nodes. One example of
> such use is the IIO subsystem's ADC channel nodes, where the relevant
> nodes are named as channel[@N].
> 
> Add a helpers for iterating and counting device's sub-nodes with certain
> name instead, of open-coding this in every user.

> Please note, the checkpatch.pl was not happy about the for_each...()
> macros. I tried to make them to follow the existing convention. I am
> open to suggestions how to improve.

You also may update .clang-format.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2025-03-10 14:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 12:53 [PATCH v6 00/10] Support ROHM BD79124 ADC Matti Vaittinen
2025-03-10 12:54 ` [PATCH v6 01/10] dt-bindings: ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-10 12:55 ` [PATCH v6 02/10] property: Add functions to iterate named child Matti Vaittinen
2025-03-10 14:25   ` Andy Shevchenko
2025-03-10 20:19     ` Jonathan Cameron
2025-03-13  6:42     ` Matti Vaittinen
2025-03-10 14:51   ` Andy Shevchenko [this message]
2025-03-10 18:12   ` Sakari Ailus
2025-03-10 12:56 ` [PATCH v6 03/10] iio: adc: add helpers for parsing ADC nodes Matti Vaittinen
2025-03-10 12:56 ` [PATCH v6 04/10] iio: adc: rzg2l_adc: Use adc-helpers Matti Vaittinen
2025-03-10 20:22   ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 05/10] iio: adc: sun20i-gpadc: " Matti Vaittinen
2025-03-10 20:23   ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 06/10] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-03-10 20:26   ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 07/10] MAINTAINERS: Add IIO ADC helpers Matti Vaittinen
2025-03-10 12:57 ` [PATCH v6 08/10] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-10 20:27 ` [PATCH v6 00/10] Support ROHM BD79124 ADC Jonathan Cameron
2025-03-11  5:49   ` Matti Vaittinen
2025-03-15 18:28     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z878bsd7i-wAuCZ6@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=dakr@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).