Linux IIO development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sa" <nuno.sa@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Guillaume Stols" <gstols@baylibre.com>,
	"Dumitru Ceclan" <mitrutzceclan@gmail.com>,
	"Trevor Gamblin" <tgamblin@baylibre.com>,
	"Matteo Martelli" <matteomartelli3@gmail.com>,
	"Alisa-Dariana Roman" <alisadariana@gmail.com>,
	"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v9 6/8] iio: adc: Support ROHM BD79124 ADC
Date: Fri, 21 Mar 2025 15:16:12 +0200	[thread overview]
Message-ID: <Z91mnHP9V0yRZ2js@smile.fi.intel.com> (raw)
In-Reply-To: <1e236993-47fc-45e9-913a-e0615787581a@gmail.com>

On Fri, Mar 21, 2025 at 02:17:16PM +0200, Matti Vaittinen wrote:
> On 21/03/2025 14:06, Andy Shevchenko wrote:
> > On Fri, Mar 21, 2025 at 10:01:00AM +0200, Matti Vaittinen wrote:
> > > On 20/03/2025 15:16, Andy Shevchenko wrote:
> > > > On Thu, Mar 20, 2025 at 10:22:00AM +0200, Matti Vaittinen wrote:
> > 
> > You can get rid of all of these by simply using __le16. I do not understand why
> > it's not used so far. I thought that bits are mirrored, that may explain the
> > case, but now I do not see any problem to use __le16 directly.
> 
> This discussion is going in circles now. That was discussed in the RFC
> review with Jonathan, which I did also tell to you during the v7 review:

Yes, because I think we all were confused by the bits representations,
but now I see it clearly and I do not understand why should we go the way
you suggested as it makes things a bit tangled in my opinion.

Jonathan, do you still think the two separate bytes are better than __le16?
If so, what are the pros of this solution?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-03-21 13:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20  8:20 [PATCH v9 0/8] Support ROHM BD79124 ADC Matti Vaittinen
2025-03-20  8:20 ` [PATCH v9 1/8] dt-bindings: ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-20  8:21 ` [PATCH v9 2/8] property: Add functions to iterate named child Matti Vaittinen
2025-03-20  8:21 ` [PATCH v9 3/8] iio: adc: add helpers for parsing ADC nodes Matti Vaittinen
2025-03-20  8:21 ` [PATCH v9 4/8] iio: adc: rzg2l_adc: Use adc-helpers Matti Vaittinen
2025-03-20 13:13   ` Claudiu Beznea
2025-03-21 12:27     ` Matti Vaittinen
2025-03-20  8:21 ` [PATCH v9 5/8] iio: adc: sun20i-gpadc: " Matti Vaittinen
2025-03-20  8:22 ` [PATCH v9 6/8] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-03-20 13:16   ` Andy Shevchenko
2025-03-20 13:38     ` Matti Vaittinen
2025-03-21  8:01     ` Matti Vaittinen
2025-03-21 12:06       ` Andy Shevchenko
2025-03-21 12:17         ` Matti Vaittinen
2025-03-21 13:16           ` Andy Shevchenko [this message]
2025-03-21 13:41             ` Matti Vaittinen
2025-03-21 13:56               ` Andy Shevchenko
2025-03-24  6:42                 ` Matti Vaittinen
2025-03-20  8:22 ` [PATCH v9 7/8] MAINTAINERS: Add IIO ADC helpers Matti Vaittinen
2025-03-20  8:22 ` [PATCH v9 8/8] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z91mnHP9V0yRZ2js@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alisadariana@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=dlechner@baylibre.com \
    --cc=gstols@baylibre.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=joao.goncalves@toradex.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteomartelli3@gmail.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mitrutzceclan@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=tgamblin@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox