From: Ingo Molnar <mingo@kernel.org>
To: david@ixit.cz
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Kees Cook" <kees@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
"Mateusz Jończyk" <mat.jonczyk@o2.pl>
Subject: Re: [PATCH v3 5/7] x86/Kconfig: Document CONFIG_PCI_MMCONFIG
Date: Sat, 22 Mar 2025 08:11:23 +0100 [thread overview]
Message-ID: <Z95im-uBoWJHmoX7@gmail.com> (raw)
In-Reply-To: <20250321-x86_x2apic-v3-5-b0cbaa6fa338@ixit.cz>
* David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org> wrote:
> From: Mateusz Jończyk <mat.jonczyk@o2.pl>
>
> This configuration option had no help text, so add it.
>
> CONFIG_EXPERT is enabled on some distribution kernels, so people using a
> distribution kernel's configuration as a starting point will see this
> option.
>
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> Signed-off-by: David Heideberg <david@ixit.cz>
> ---
> arch/x86/Kconfig | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index fbc9ba30fd1cbfb574399a0632b9f77876ba84a8..64a1e00619df95f559488e3004558a7b0f653df3 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2914,6 +2914,19 @@ config PCI_MMCONFIG
> default y
> depends on PCI && (ACPI || JAILHOUSE_GUEST)
> depends on X86_64 || (PCI_GOANY || PCI_GOMMCONFIG)
> + help
> + Add support for accessing the PCI configuration space as a memory
> + mapped area. It is the recommended method if the system supports
> + this (it must have PCI Express and ACPI for it to be available).
> +
> + In the unlikely case that enabling this configuration option causes
> + problems, the mechanism can be switched off with the 'pci=nommconf'
> + command line parameter.
> +
> + Say 'n' only if you are sure that your platform does not support this
> + access method or you have problems caused by it.
> +
> + Say 'y' otherwise.
For future reference, the canonical incantantion in Kconfig lore is:
Say Y otherwise.
I have fixed it up in this commit.
Thanks,
Ingo
next prev parent reply other threads:[~2025-03-22 7:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 20:48 [PATCH v3 0/7] x86: Kconfig cleanups and help text improvements David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 1/7] x86/Kconfig: Enable X86_X2APIC by default and improve help text David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 2/7] x86/Kconfig: Always enable ARCH_SPARSEMEM_ENABLE David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 3/7] x86/Kconfig: Move all X86_EXTENDED_PLATFORM options together David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 4/7] x86/Kconfig: Update lists in X86_EXTENDED_PLATFORM David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 5/7] x86/Kconfig: Document CONFIG_PCI_MMCONFIG David Heidelberg via B4 Relay
2025-03-22 7:11 ` Ingo Molnar [this message]
2025-03-21 20:48 ` [PATCH v3 6/7] x86/Kconfig: Make CONFIG_PCI_CNB20LE_QUIRK depend on X86_32 David Heidelberg via B4 Relay
2025-03-21 20:48 ` [PATCH v3 7/7] x86/Kconfig: Document release year of glibc 2.3.3 David Heidelberg via B4 Relay
2025-03-22 7:28 ` Ingo Molnar
2025-03-22 15:13 ` [PATCH v3 0/7] x86: Kconfig cleanups and help text improvements Mateusz Jończyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z95im-uBoWJHmoX7@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@ixit.cz \
--cc=hpa@zytor.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox